github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2611] PM-171 remove confirmation alert for restore item click in trash #3679

New Issue
Closed
opened 2025-11-26 23:36:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:36:03 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2611

State: closed
Merged: No

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • [ X ] Other

Objective

Removing the confirmation alert for restoring an item from Trash

Confirmation alerts should only be used as warnings if something is being deleted or for irreversible actions. Restoring an item does not fall under this definition.

Code changes

Removed confirmation alert lines for restore inside src/App/Pages/Vault/CipherDetailsPageViewModel.cs

Screenshots

https://github.com/bitwarden/mobile/assets/8302660/0e7a738f-4dcd-446c-b9f2-3dc32a65cdfe

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2611 **State:** closed **Merged:** No --- ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ X ] Other ## Objective Removing the confirmation alert for restoring an item from Trash Confirmation alerts should only be used as warnings if something is being deleted or for irreversible actions. Restoring an item does not fall under this definition. ## Code changes Removed confirmation alert lines for restore inside `src/App/Pages/Vault/CipherDetailsPageViewModel.cs` ## Screenshots https://github.com/bitwarden/mobile/assets/8302660/0e7a738f-4dcd-446c-b9f2-3dc32a65cdfe ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:36:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3679
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?