github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2610] [PM-1201] Change timeout actions available based on hasMasterPassword #3678

New Issue
Closed
opened 2025-11-26 23:36:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:36:02 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2610

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

For users without a master password, the unlock settings need to be different:

  • Vault timeout action defaults to “log out”
  • Vault timeout action “lock” is only available as an option if the user has enabled PIN unlock or biometrics unlock.
  • If user disables PIN/Biometric unlock methods, then the vault timeout action defaults back to “log out”

Code changes

  • Get DecryptionOptions to check if the user has master password set.
    if the user doesn't have a master password set up:
  • Change PIN and Biometric disable logic to reset timeout action to Logout
  • Change default timeout action to logout if there is no saved action.

Screenshots

https://github.com/bitwarden/mobile/assets/4648522/972cd706-61a7-4c35-bab6-9368848dc6d2

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2610 **State:** closed **Merged:** Yes --- ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> For users without a master password, the unlock settings need to be different: - Vault timeout action defaults to “log out” - Vault timeout action “lock” is only available as an option if the user has enabled PIN unlock or biometrics unlock. - If user disables PIN/Biometric unlock methods, then the vault timeout action defaults back to “log out” ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> - Get DecryptionOptions to check if the user has master password set. if the user doesn't have a master password set up: - Change PIN and Biometric disable logic to reset timeout action to Logout - Change default timeout action to logout if there is no saved action. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://github.com/bitwarden/mobile/assets/4648522/972cd706-61a7-4c35-bab6-9368848dc6d2 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:36:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?