github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2606] [PM-2901] Synchronize sends on send creation/update/deletion notification #3675

New Issue
Closed
opened 2025-11-26 23:36:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:36:00 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2606

State: closed
Merged: Yes

Type of change

  • Bug fix
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • New feature development
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes #2571. On desktop/web, sends are synced when the Websocket notification notifying the clients of the creation/update/deletion arrives. On mobile this is not implemented. This PR brings feature parity in that regard by implementing syncing send creation/updates/deletions on arrival of the Firebase notification.

Beware, I was not able to fully test this as the default config builds for the QA push environment.

Code changes

  • PushNotificationListenerService.cs Add code handling the 3 send notification types (creation, update, deletion). The code is pretty much the same as for ciphers.
  • NotificationResponse.cs Add a class to contain send sync notification data
  • ISyncService.cs, SyncService.cs Add code for doing a sync for sends.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2606 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [x] New feature development - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fixes #2571. On desktop/web, sends are synced when the Websocket notification notifying the clients of the creation/update/deletion arrives. On mobile this is not implemented. This PR brings feature parity in that regard by implementing syncing send creation/updates/deletions on arrival of the Firebase notification. Beware, I was not able to fully test this as the default config builds for the QA push environment. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * PushNotificationListenerService.cs Add code handling the 3 send notification types (creation, update, deletion). The code is pretty much the same as for ciphers. * NotificationResponse.cs Add a class to contain send sync notification data * ISyncService.cs, SyncService.cs Add code for doing a sync for sends. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:36:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?