github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5987] [MERGED] PM-26689: Separate share logic from IntentManager #36712

New Issue
Closed
opened 2026-04-21 03:52:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 03:52:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5987
Author: @david-livefront
Created: 10/8/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @david-livefront

Base: main ← Head: PM-26689-share-manager

📝 Commits (2)

  • 48f218a PM-26689: Separate share logic from IntentManager
  • 29d2acb Inject IntentManager with Activity

📊 Changes

15 files changed (+182 additions, -159 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt (+3 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt (+3 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/di/PlatformUiManagerModule.kt (+12 -15)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/SpecialCircumstanceExtensions.kt (+5 -5)
📝 app/src/test/kotlin/com/x8bit/bitwarden/MainViewModelTest.kt (+9 -8)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt (+2 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/SpecialCircumstanceExtensionsTest.kt (+5 -5)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManager.kt (+3 -32)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManagerImpl.kt (+16 -83)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/manager/share/ShareManager.kt (+14 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/manager/share/ShareManagerImpl.kt (+43 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/manager/share/model/ShareData.kt (+27 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/util/ContextExtensions.kt (+37 -0)

📄 Description

🎟️ Tracking

PM-26689

📔 Objective

This PR separates the ShareData logic from the IntentManager. This change allows the IntentManager to be UI only and we can pass a full Activity into it, this will be required for AuthTab functionality.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5987 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-26689-share-manager` --- ### 📝 Commits (2) - [`48f218a`](https://github.com/bitwarden/android/commit/48f218a770d8f5513dfe267bddea5b054ebf6043) PM-26689: Separate share logic from IntentManager - [`29d2acb`](https://github.com/bitwarden/android/commit/29d2acbf8de7550c1808611e5524b6a47ae831dc) Inject IntentManager with Activity ### 📊 Changes **15 files changed** (+182 additions, -159 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt` (+3 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt` (+3 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/di/PlatformUiManagerModule.kt` (+12 -15) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/SpecialCircumstanceExtensions.kt` (+5 -5) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/MainViewModelTest.kt` (+9 -8) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt` (+2 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/SpecialCircumstanceExtensionsTest.kt` (+5 -5) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManager.kt` (+3 -32) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManagerImpl.kt` (+16 -83) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/manager/share/ShareManager.kt` (+14 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/manager/share/ShareManagerImpl.kt` (+43 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/manager/share/model/ShareData.kt` (+27 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/util/ContextExtensions.kt` (+37 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-26689](https://bitwarden.atlassian.net/browse/PM-26689) ## 📔 Objective This PR separates the `ShareData` logic from the `IntentManager`. This change allows the `IntentManager` to be UI only and we can pass a full `Activity` into it, this will be required for `AuthTab` functionality. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-26689]: https://bitwarden.atlassian.net/browse/PM-26689?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 03:52:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#36712
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?