github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5788] [MERGED] [PM-25057] Refactor card restriction logic in AutofillCipherProvider #36549

New Issue
Closed
opened 2026-04-21 03:44:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 03:44:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5788
Author: @SaintPatrck
Created: 8/26/2025
Status: ✅ Merged
Merged: 8/26/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-25057/restict-personal-vault-cards

📝 Commits (1)

  • 58ccd80 PM-25057 Refactor card restriction logic in AutofillCipherProvider

📊 Changes

2 files changed (+41 additions, -3 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/provider/AutofillCipherProviderImpl.kt (+24 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/processor/AutofillCipherProviderTest.kt (+17 -2)

📄 Description

🎟️ Tracking

PM-25057

📔 Objective

Correct the logic for handling organization-based card type restrictions within the autofill feature.

The isExcludedByOrgCardRestrictions function was introduced in AutofillCipherProviderImpl.kt to consolidate the logic for determining if a CipherListView item should be excluded due to these restrictions. This function now correctly handles cases where:

  • The item is a personal vault item and any organization has card type restrictions.
  • The item belongs to an organization that has card type restrictions.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5788 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 8/26/2025 **Status:** ✅ Merged **Merged:** 8/26/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-25057/restict-personal-vault-cards` --- ### 📝 Commits (1) - [`58ccd80`](https://github.com/bitwarden/android/commit/58ccd803fb3d66df4072c1e4d26c7bb53b040931) [PM-25057] Refactor card restriction logic in AutofillCipherProvider ### 📊 Changes **2 files changed** (+41 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/provider/AutofillCipherProviderImpl.kt` (+24 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/processor/AutofillCipherProviderTest.kt` (+17 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-25057](https://bitwarden.atlassian.net/browse/PM-25057) ## 📔 Objective Correct the logic for handling organization-based card type restrictions within the autofill feature. The `isExcludedByOrgCardRestrictions` function was introduced in `AutofillCipherProviderImpl.kt` to consolidate the logic for determining if a `CipherListView` item should be excluded due to these restrictions. This function now correctly handles cases where: - The item is a personal vault item and any organization has card type restrictions. - The item belongs to an organization that has card type restrictions. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-25057]: https://bitwarden.atlassian.net/browse/PM-25057?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 03:44:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#36549
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?