github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 16:57:18 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2572] [MERGED] [PM-2645] Adding IDs for Account Switching elements #3652

New Issue
Closed
opened 2025-11-26 23:35:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2572
Author: @ifernandezdiaz
Created: 6/16/2023
Status: ✅ Merged
Merged: 6/16/2023
Merged by: @ifernandezdiaz

Base: master ← Head: PM-2645/automationIDs-account-switching-elements

📝 Commits (2)

  • d843bfc Adding IDs for Account Switching elements
  • 4127f11 Fixing Active/Inactive vault icon IDs

📊 Changes

9 files changed (+40 additions, -23 deletions)

View changed files

📝 src/App/Controls/AccountSwitchingOverlay/AccountSwitchingOverlayView.xaml (+3 -1)
📝 src/App/Controls/AccountViewCell/AccountViewCell.xaml (+19 -10)
📝 src/App/Pages/Accounts/HomePage.xaml (+2 -1)
📝 src/App/Pages/Accounts/LockPage.xaml (+6 -5)
📝 src/App/Pages/Accounts/LoginPage.xaml (+3 -2)
📝 src/App/Pages/Generator/GeneratorPage.xaml (+1 -1)
📝 src/App/Pages/Send/SendAddOnlyPage.xaml (+2 -1)
📝 src/App/Pages/Vault/CipherSelectionPage.xaml (+2 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml (+2 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • AccountSwitchingOverlayView.xaml: Adding IDs for Cells and Cell container
  • AccountViewCell.xaml: Adding IDs for every Cell component
  • HomePage.xaml: Adding Id for Account Icon element
  • LockPage.xaml: Adding Id for Account Icon element
  • LoginPage.xaml: Adding Id for Account Icon element
  • SendAddOnlyPage.xaml: Adding Id for Account Icon element
  • CipherSelectionPage.xaml: Adding Id for Account Icon element
  • GroupingsPage.xaml: Adding Id for Account Icon element
  • GeneratorPage.xaml: Fixing wrong locator

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2572 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 6/16/2023 **Status:** ✅ Merged **Merged:** 6/16/2023 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `master` ← **Head:** `PM-2645/automationIDs-account-switching-elements` --- ### 📝 Commits (2) - [`d843bfc`](https://github.com/bitwarden/android/commit/d843bfc9efabe0b12a4c20267cdec98e909509ff) Adding IDs for Account Switching elements - [`4127f11`](https://github.com/bitwarden/android/commit/4127f11b9e3a8d6e74506a92d3a289127c83f470) Fixing Active/Inactive vault icon IDs ### 📊 Changes **9 files changed** (+40 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/AccountSwitchingOverlay/AccountSwitchingOverlayView.xaml` (+3 -1) 📝 `src/App/Controls/AccountViewCell/AccountViewCell.xaml` (+19 -10) 📝 `src/App/Pages/Accounts/HomePage.xaml` (+2 -1) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+6 -5) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+3 -2) 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+1 -1) 📝 `src/App/Pages/Send/SendAddOnlyPage.xaml` (+2 -1) 📝 `src/App/Pages/Vault/CipherSelectionPage.xaml` (+2 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml` (+2 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests ## Code changes * **AccountSwitchingOverlayView.xaml:** Adding IDs for Cells and Cell container * **AccountViewCell.xaml:** Adding IDs for every Cell component * **HomePage.xaml:** Adding Id for Account Icon element * **LockPage.xaml:** Adding Id for Account Icon element * **LoginPage.xaml:** Adding Id for Account Icon element * **SendAddOnlyPage.xaml:** Adding Id for Account Icon element * **CipherSelectionPage.xaml:** Adding Id for Account Icon element * **GroupingsPage.xaml:** Adding Id for Account Icon element * **GeneratorPage.xaml:** Fixing wrong locator ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3652
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?