github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 20:24:33 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2568] [MERGED] [PM-2575] Fix extension freeze when using the return button on the keyboard when unlocking #3649

New Issue
Closed
opened 2025-11-26 23:35:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2568
Author: @fedemkr
Created: 6/13/2023
Status: ✅ Merged
Merged: 6/13/2023
Merged by: @fedemkr

Base: master ← Head: PM-2575-fix-go-button-argon2id-autofill

📝 Commits (1)

  • 00d7a1a PM-2575 Fixed extension freeze when using the return button on the keyboard when unlocking the extension. Also added way to prevent multiple executions of checking the password and logging exceptions.

📊 Changes

4 files changed (+96 additions, -81 deletions)

View changed files

📝 src/App/Resources/AppResources.Designer.cs (+1 -1)
📝 src/App/Resources/AppResources.resx (+1 -1)
📝 src/iOS.Autofill/LockPasswordViewController.cs (+2 -1)
📝 src/iOS.Core/Controllers/BaseLockPasswordViewController.cs (+92 -78)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix extension freeze when tapping the "Go" (return button) on the keyboard when unlocking.

Code changes

  • BaseLockPasswordViewController: GetAwaiter().GetResult() was causing a deadlock, so changed that to FireAndForget() which also logs exceptions, if any. And added the flag so that we avoid multiple executions. Just in case, there seems to be a lot of line changes but it's mainly adding a try...finally
  • LockPasswordViewController: Added FireAndForget so that we log the exceptions, if any.
  • AppResources: Added period in the warning for the argon2id.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2568 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 6/13/2023 **Status:** ✅ Merged **Merged:** 6/13/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `PM-2575-fix-go-button-argon2id-autofill` --- ### 📝 Commits (1) - [`00d7a1a`](https://github.com/bitwarden/android/commit/00d7a1a2dfd86aa8d3f4befa3c567f3fd50ed5fc) PM-2575 Fixed extension freeze when using the return button on the keyboard when unlocking the extension. Also added way to prevent multiple executions of checking the password and logging exceptions. ### 📊 Changes **4 files changed** (+96 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Resources/AppResources.Designer.cs` (+1 -1) 📝 `src/App/Resources/AppResources.resx` (+1 -1) 📝 `src/iOS.Autofill/LockPasswordViewController.cs` (+2 -1) 📝 `src/iOS.Core/Controllers/BaseLockPasswordViewController.cs` (+92 -78) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix extension freeze when tapping the "Go" (return button) on the keyboard when unlocking. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **BaseLockPasswordViewController:** `GetAwaiter().GetResult()` was causing a deadlock, so changed that to `FireAndForget()` which also logs exceptions, if any. And added the flag so that we avoid multiple executions. Just in case, there seems to be a lot of line changes but it's mainly adding a `try...finally` * **LockPasswordViewController:** Added `FireAndForget` so that we log the exceptions, if any. * **AppResources:** Added period in the warning for the argon2id. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3649
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?