github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 18:43:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2563] [CLOSED] [PM-2544] Adding AutomationIDs for CipherAddEditViewPage elements #3646

New Issue
Closed
opened 2025-11-26 23:35:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2563
Author: @ifernandezdiaz
Created: 6/9/2023
Status: ❌ Closed

Base: master ← Head: PM-2544/adding-automationIDs-on-add-edit-cipher-views

📝 Commits (2)

  • fbb3bca Adding new Ids to CipherAddEditView page
  • 9a508b9 Removing autogenerated files

📊 Changes

32 files changed (+143 additions, -2713 deletions)

View changed files

📝 src/App/Lists/ItemLayouts/CustomFields/BooleanCustomFieldItemLayout.xaml (+6 -3)
📝 src/App/Lists/ItemLayouts/CustomFields/HiddenCustomFieldItemLayout.xaml (+8 -4)
📝 src/App/Lists/ItemLayouts/CustomFields/LinkedCustomFieldItemLayout.xaml (+8 -4)
📝 src/App/Lists/ItemLayouts/CustomFields/TextCustomFieldItemLayout.xaml (+10 -5)
📝 src/App/Pages/Vault/CipherAddEditPage.xaml (+111 -58)
➖ src/App/Resources/AppResources.cs.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.da.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.de.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.es.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.fi.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.fr.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.hi.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.hr.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.hu.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.id.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.it.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.it.resx (+0 -2639)
➖ src/App/Resources/AppResources.ja.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.nl.Designer.cs (+0 -0)
➖ src/App/Resources/AppResources.pl.Designer.cs (+0 -0)

...and 12 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • CipherAddEditPage.xaml: Adding locators for all the Login/Card/SecureNote/Identity item fields
  • TextCustomFieldItemLayout.xaml: Adding locators for title/value fields
  • BooleanCustomFieldItemLayout.xaml: Adding locators for title/value fields
  • HiddenCustomFieldItemLayout.xaml: Adding locators for title/value fields
  • LinkedCustomFieldItemLayout.xaml: Adding locators for title/value fields

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2563 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 6/9/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `PM-2544/adding-automationIDs-on-add-edit-cipher-views` --- ### 📝 Commits (2) - [`fbb3bca`](https://github.com/bitwarden/android/commit/fbb3bcaef77e40056c32f742b6b72c9501e1df63) Adding new Ids to CipherAddEditView page - [`9a508b9`](https://github.com/bitwarden/android/commit/9a508b971f6543b33381aee7f3cc9eba335e2b22) Removing autogenerated files ### 📊 Changes **32 files changed** (+143 additions, -2713 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Lists/ItemLayouts/CustomFields/BooleanCustomFieldItemLayout.xaml` (+6 -3) 📝 `src/App/Lists/ItemLayouts/CustomFields/HiddenCustomFieldItemLayout.xaml` (+8 -4) 📝 `src/App/Lists/ItemLayouts/CustomFields/LinkedCustomFieldItemLayout.xaml` (+8 -4) 📝 `src/App/Lists/ItemLayouts/CustomFields/TextCustomFieldItemLayout.xaml` (+10 -5) 📝 `src/App/Pages/Vault/CipherAddEditPage.xaml` (+111 -58) ➖ `src/App/Resources/AppResources.cs.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.da.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.de.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.es.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.fi.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.fr.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.hi.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.hr.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.hu.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.id.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.it.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.it.resx` (+0 -2639) ➖ `src/App/Resources/AppResources.ja.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.nl.Designer.cs` (+0 -0) ➖ `src/App/Resources/AppResources.pl.Designer.cs` (+0 -0) _...and 12 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests ## Code changes * **CipherAddEditPage.xaml:** Adding locators for all the Login/Card/SecureNote/Identity item fields * **TextCustomFieldItemLayout.xaml:** Adding locators for title/value fields * **BooleanCustomFieldItemLayout.xaml:** Adding locators for title/value fields * **HiddenCustomFieldItemLayout.xaml:** Adding locators for title/value fields * **LinkedCustomFieldItemLayout.xaml:** Adding locators for title/value fields ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3646
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?