github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-24 23:32:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2561] [MERGED] [PM-2392] Enhancement to login field detection for Android autofill #3644

New Issue
Closed
opened 2025-11-26 23:35:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2561
Author: @mpbw2
Created: 6/7/2023
Status: ✅ Merged
Merged: 6/13/2023
Merged by: @mpbw2

Base: master ← Head: enhancement-autofill

📝 Commits (1)

  • b6fe976 Enhancement to login field detection for Android autofill

📊 Changes

1 file changed (+20 additions, -19 deletions)

View changed files

📝 src/Android/Autofill/FieldCollection.cs (+20 -19)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR allows user/pass field detection to utilize fallback code on both fields if hints are only available for one (previously a single hint would prevent fallback detection from executing resulting in only the username or password field being filled).

#1389

Code changes

  • FieldCollection.cs: Only return if matching hint found, otherwise execute fallback detection in PasswordFields & UsernameFields

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2561 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 6/7/2023 **Status:** ✅ Merged **Merged:** 6/13/2023 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `enhancement-autofill` --- ### 📝 Commits (1) - [`b6fe976`](https://github.com/bitwarden/android/commit/b6fe976b35b56923c5c40619e5f21d70773f8ebc) Enhancement to login field detection for Android autofill ### 📊 Changes **1 file changed** (+20 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/FieldCollection.cs` (+20 -19) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR allows user/pass field detection to utilize fallback code on both fields if hints are only available for one (previously a single hint would prevent fallback detection from executing resulting in only the username or password field being filled). #1389 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **FieldCollection.cs:** Only return if matching hint found, otherwise execute fallback detection in `PasswordFields` & `UsernameFields` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3644
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?