github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 93 Wiki Activity

[PR #2560] [MERGED] [PM-1076] Added warning on unlocking iOS extensions for argon2id memory #3643

New Issue
Closed
opened 2025-11-26 23:35:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2560
Author: @fedemkr
Created: 6/6/2023
Status: ✅ Merged
Merged: 6/7/2023
Merged by: @fedemkr

Base: master ← Head: PM-1076-warning-argon2id-ios-extensions

📝 Commits (1)

  • dfbb2a1 PM-1076 added warning on unlocking iOS extensions when the kdf type is argon2id and the memory is higher than 48MB, to let the user know that unlocking might crash the extension

📊 Changes

4 files changed (+25 additions, -0 deletions)

View changed files

📝 src/App/Resources/AppResources.Designer.cs (+9 -0)
📝 src/App/Resources/AppResources.resx (+3 -0)
📝 src/iOS.Core/Constants.cs (+1 -0)
📝 src/iOS.Core/Controllers/BaseLockPasswordViewController.cs (+12 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add warning to the user when unlocking iOS extensions when using Argon2Id when the memory is higher than what the extension could handle, which causes the extension to crash.

Code changes

  • BaseLockPasswordViewController: Added warning for argon2id when memory configured may crash the extension

Screenshots

iOS Extensions argon2id memory warning

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2560 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 6/6/2023 **Status:** ✅ Merged **Merged:** 6/7/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `PM-1076-warning-argon2id-ios-extensions` --- ### 📝 Commits (1) - [`dfbb2a1`](https://github.com/bitwarden/android/commit/dfbb2a1125ced784142696cbbf2252c8e5c44a98) PM-1076 added warning on unlocking iOS extensions when the kdf type is argon2id and the memory is higher than 48MB, to let the user know that unlocking might crash the extension ### 📊 Changes **4 files changed** (+25 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Resources/AppResources.Designer.cs` (+9 -0) 📝 `src/App/Resources/AppResources.resx` (+3 -0) 📝 `src/iOS.Core/Constants.cs` (+1 -0) 📝 `src/iOS.Core/Controllers/BaseLockPasswordViewController.cs` (+12 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add warning to the user when unlocking iOS extensions when using Argon2Id when the memory is higher than what the extension could handle, which causes the extension to crash. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **BaseLockPasswordViewController:** Added warning for argon2id when memory configured may crash the extension ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="314" alt="iOS Extensions argon2id memory warning" src="https://github.com/bitwarden/mobile/assets/15682323/51d47f1d-5e09-4ab4-979d-27ba2f728ab0"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3643
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?