github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2535] [MERGED] [PM-1379] add DeviceTrustCryptoService with establish trust logic #3621

New Issue
Closed
opened 2025-11-26 23:35:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2535
Author: @jlf0dev
Created: 5/23/2023
Status: ✅ Merged
Merged: 7/5/2023
Merged by: @jlf0dev

Base: feature/pm-1029-tde-login ← Head: pm-1379-establish-trust

📝 Commits (10+)

  • 973e909 [PM-1379] add DeviceCryptoService with establish trust logic
  • 5b33c92 PM-1379 update api location and other minor refactors
  • c700941 Merge branch 'master' into pm-1379-establish-trust
  • 599cacb pm-1379 fix encoding
  • a242b8b update trusted device keys api call to Put
  • e455b28 [PM-1379] rename DeviceCryptoService to DeviceTrustCryptoService
  • c578aa9 [PM-1379] rearrange methods in DeviceTrustCryptoService
  • 2cc1fa4 [PM-1379] rearrange methods in abstraction
  • 699f876 [PM-1379] deconstruct tuples
  • a9b361e [PM-1379] remove extra tasks

📊 Changes

9 files changed (+141 additions, -0 deletions)

View changed files

📝 src/Core/Abstractions/IApiService.cs (+2 -0)
➕ src/Core/Abstractions/IDeviceTrustCryptoService.cs (+11 -0)
📝 src/Core/Abstractions/IStateService.cs (+2 -0)
📝 src/Core/Constants.cs (+1 -0)
➕ src/Core/Models/Request/TrustedDeviceKeysRequest.cs (+10 -0)
➕ src/Core/Models/Response/DeviceResponse.cs (+13 -0)
📝 src/Core/Services/ApiService.cs (+10 -0)
➕ src/Core/Services/DeviceTrustCryptoService.cs (+81 -0)
📝 src/Core/Services/StateService.cs (+11 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Adds the Establish Trust logic to mobile. More information and clients equivalent in bitwarden/clients#5339

Code changes

  • DeviceTrustCryptoService: Will be responsible for handling the device specific key related methods, such as the trusted device ones in there.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2535 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 5/23/2023 **Status:** ✅ Merged **Merged:** 7/5/2023 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `feature/pm-1029-tde-login` ← **Head:** `pm-1379-establish-trust` --- ### 📝 Commits (10+) - [`973e909`](https://github.com/bitwarden/android/commit/973e9092fd94d7f9cb6e60cceba716733ddc3fe5) [PM-1379] add DeviceCryptoService with establish trust logic - [`5b33c92`](https://github.com/bitwarden/android/commit/5b33c9245a3b912f6f47363a8835aed006316070) PM-1379 update api location and other minor refactors - [`c700941`](https://github.com/bitwarden/android/commit/c700941b4620c587f731eafb056fbdf6af7d4c99) Merge branch 'master' into pm-1379-establish-trust - [`599cacb`](https://github.com/bitwarden/android/commit/599cacbe0dc04dc6d2f90f27597b30e811b335b5) pm-1379 fix encoding - [`a242b8b`](https://github.com/bitwarden/android/commit/a242b8b3d608fadd3b8a96c18e3901865a329b96) update trusted device keys api call to Put - [`e455b28`](https://github.com/bitwarden/android/commit/e455b28accd4f3a4cb51c2d819c05addb017f9f3) [PM-1379] rename DeviceCryptoService to DeviceTrustCryptoService - [`c578aa9`](https://github.com/bitwarden/android/commit/c578aa9796c1337a16b81da83c4e48daf63ac1f0) [PM-1379] rearrange methods in DeviceTrustCryptoService - [`2cc1fa4`](https://github.com/bitwarden/android/commit/2cc1fa47a7ac347d20df660587bbd7d7cab380ff) [PM-1379] rearrange methods in abstraction - [`699f876`](https://github.com/bitwarden/android/commit/699f8763bc5a251cc10bda0896ca260f9362a6a4) [PM-1379] deconstruct tuples - [`a9b361e`](https://github.com/bitwarden/android/commit/a9b361ea8fa0ed619bdd6099ef0ce865912466b9) [PM-1379] remove extra tasks ### 📊 Changes **9 files changed** (+141 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/IApiService.cs` (+2 -0) ➕ `src/Core/Abstractions/IDeviceTrustCryptoService.cs` (+11 -0) 📝 `src/Core/Abstractions/IStateService.cs` (+2 -0) 📝 `src/Core/Constants.cs` (+1 -0) ➕ `src/Core/Models/Request/TrustedDeviceKeysRequest.cs` (+10 -0) ➕ `src/Core/Models/Response/DeviceResponse.cs` (+13 -0) 📝 `src/Core/Services/ApiService.cs` (+10 -0) ➕ `src/Core/Services/DeviceTrustCryptoService.cs` (+81 -0) 📝 `src/Core/Services/StateService.cs` (+11 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Adds the Establish Trust logic to mobile. More information and clients equivalent in bitwarden/clients#5339 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> - **DeviceTrustCryptoService:** Will be responsible for handling the device specific key related methods, such as the trusted device ones in there. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3621
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?