github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 03:09:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2526] [CLOSED] [PM-2313] Allow empty passphrase separator #3618

New Issue
Closed
opened 2025-11-26 23:35:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2526
Author: @joseph082
Created: 5/19/2023
Status: ❌ Closed

Base: main ← Head: feature/allow-empty-passphrase-separator

📝 Commits (3)

  • 6b61a98 Allow empty passphrase separator
  • dbb964c Merge branch 'master' into feature/allow-empty-passphrase-separator
  • 2a0f636 Merge branch 'main' into feature/allow-empty-passphrase-separator

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Core/Services/PasswordGenerationService.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Closes #2525
Allow empty passphrase word separator in passphrase generator

Code changes

  • PasswordGenerationService.cs: Removed the check for an empty wordSeparator where currently, it is defaulted to a space. Now, the wordSeparator will remain as the empty string.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2526 **Author:** [@joseph082](https://github.com/joseph082) **Created:** 5/19/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/allow-empty-passphrase-separator` --- ### 📝 Commits (3) - [`6b61a98`](https://github.com/bitwarden/android/commit/6b61a9819ae93a8d2482e195a2994c41d2ec6598) Allow empty passphrase separator - [`dbb964c`](https://github.com/bitwarden/android/commit/dbb964cde985d106ff4608fc1763ddba663d068b) Merge branch 'master' into feature/allow-empty-passphrase-separator - [`2a0f636`](https://github.com/bitwarden/android/commit/2a0f63673e76920bdfdad42c134c3ed510ee51d7) Merge branch 'main' into feature/allow-empty-passphrase-separator ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/PasswordGenerationService.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Closes #2525 Allow empty passphrase word separator in passphrase generator ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **PasswordGenerationService.cs:** Removed the check for an empty wordSeparator where currently, it is defaulted to a space. Now, the wordSeparator will remain as the empty string. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3618
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?