github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5334] [MERGED] [PM-22523] PM-19476: Allow empty string as word separator #36179

New Issue
Closed
opened 2026-04-21 03:25:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 03:25:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5334
Author: @EranBoudjnah
Created: 6/9/2025
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @SaintPatrck

Base: main ← Head: PM-19476-default-to-no-word-separator

📝 Commits (4)

  • 821851f PM-19476: Changed default passphrase word separator to empty string.
  • 2914739 PM-19476: Reverted change to MasterPasswordGeneratorViewModel.
  • cb7303f PM-19476: Added test to validate fix.
  • c0f0b3b PM-19476: Reformatted.

📊 Changes

3 files changed (+36 additions, -1 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/tools/generator/repository/util/FakeGeneratorRepository.kt (+10 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt (+25 -0)

📄 Description

🎟️ Tracking

https://github.com/bitwarden/android/issues/4913

📔 Objective

Allow users to use no separator in passphrases.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
Screenshot_20260205_181117 Screenshot_20260205_181703

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5334 **Author:** [@EranBoudjnah](https://github.com/EranBoudjnah) **Created:** 6/9/2025 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-19476-default-to-no-word-separator` --- ### 📝 Commits (4) - [`821851f`](https://github.com/bitwarden/android/commit/821851fe8181b10796a30f38eda97798e5b976ad) PM-19476: Changed default passphrase word separator to empty string. - [`2914739`](https://github.com/bitwarden/android/commit/2914739ce34ce20488b9421708604729622516e0) PM-19476: Reverted change to MasterPasswordGeneratorViewModel. - [`cb7303f`](https://github.com/bitwarden/android/commit/cb7303f51bfd09fe59cabef46756e17260869d6d) PM-19476: Added test to validate fix. - [`c0f0b3b`](https://github.com/bitwarden/android/commit/c0f0b3b5ff8823278f230961f82c9047d3d47965) PM-19476: Reformatted. ### 📊 Changes **3 files changed** (+36 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/tools/generator/repository/util/FakeGeneratorRepository.kt` (+10 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt` (+25 -0) </details> ### 📄 Description ## 🎟️ Tracking https://github.com/bitwarden/android/issues/4913 ## 📔 Objective Allow users to use no separator in passphrases. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes <img width="1080" height="2424" alt="Screenshot_20260205_181117" src="https://github.com/user-attachments/assets/3d920ef1-3f34-4099-8e6c-d0a8c543c8dd" /> <img width="1080" height="2424" alt="Screenshot_20260205_181703" src="https://github.com/user-attachments/assets/07622113-19f4-4876-84a5-71cf5ed39eb7" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 03:25:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#36179
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?