github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2520] [CLOSED] Add automatic application of needs-qa label on PRs to master #3614

New Issue
Closed
opened 2025-11-26 23:35:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2520
Author: @trmartin4
Created: 5/12/2023
Status: ❌ Closed

Base: main ← Head: add-needs-qa-label

📝 Commits (10+)

📊 Changes

1 file changed (+23 additions, -0 deletions)

View changed files

➕ .github/workflows/label-issue-pull-request.yml (+23 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

For PRs against master, we want to enforce a needs-qa label. We currently have an enforce-labels action that will prevent merging if the needs-qa label exists. Currently we rely on the engineer to remember to add it when they create the PR. This action will run on PR creation and automatically add the label.

The equivalent action is already in place on the clients repo.

Code changes

  • label-issue-pull-request.yml: New workflow to apply the needs-qa label.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2520 **Author:** [@trmartin4](https://github.com/trmartin4) **Created:** 5/12/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add-needs-qa-label` --- ### 📝 Commits (10+) - [`570b563`](https://github.com/bitwarden/android/commit/570b56364a1e8f05de4669ae5819d62235251f38) Autosync the updated translations (#2030) - [`3ef5b57`](https://github.com/bitwarden/android/commit/3ef5b576ac2fc25cb5b59b8eae8bd8dd0805799c) [EC-371] Fix iOS extensions login more menu (#2016) - [`4fbe1b4`](https://github.com/bitwarden/android/commit/4fbe1b40e3ea8a666fd5d80236db45899bc4e16d) Autosync the updated translations (#2035) - [`e04b250`](https://github.com/bitwarden/android/commit/e04b250a73ff7c465f65055f04caf38d7410969a) Add renovate config (#2034) - [`6159758`](https://github.com/bitwarden/android/commit/61597585b5a519325c8312b9fecf2d65eaa611af) [PS-1219] Crash when login with SSO (#2023) - [`de41845`](https://github.com/bitwarden/android/commit/de41845e3e7d7b0020ef57e2d0310c5068d3956a) Bumped version to 2022.8.1 (#2039) - [`8b11840`](https://github.com/bitwarden/android/commit/8b118408fa89e972caa0290041638052f9decd8e) Add workaround for broken windows 2022 runner (#2040) - [`5f7a1e7`](https://github.com/bitwarden/android/commit/5f7a1e769ab759cecb6b09db49ac07bd1ce58f03) Changed the right margin of the switch at Create Account(#2021) - [`3d9555d`](https://github.com/bitwarden/android/commit/3d9555d4208571ec063cd934fbb9014c252ff6d5) [PS-1009] Changed keyboard on Passphrase generator to not allow emojis (#2038) - [`e829279`](https://github.com/bitwarden/android/commit/e829279e29cf611ac6b1f400d29e9a5085ecb5d5) [SG-416] Updates to Bitwarden Authenticator (Feature Branch) (#2041) ### 📊 Changes **1 file changed** (+23 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/label-issue-pull-request.yml` (+23 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ## Objective For PRs against `master`, we want to enforce a `needs-qa` label. We currently have an `enforce-labels` action that will prevent merging if the `needs-qa` label exists. Currently we rely on the engineer to remember to add it when they create the PR. This action will run on PR creation and automatically add the label. The equivalent action is already in place on the `clients` repo. ## Code changes * **label-issue-pull-request.yml:** New workflow to apply the `needs-qa` label. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?