github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-21 22:00:42 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2489] [MERGED] [PM-1906] Fix syncing issue with new policies method to update Vault Timeout #3591

New Issue
Closed
opened 2025-11-26 23:34:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2489
Author: @jlf0dev
Created: 4/21/2023
Status: ✅ Merged
Merged: 4/21/2023
Merged by: @jlf0dev

Base: master ← Head: pm-1906-sync-failing-policies

📝 Commits (1)

  • 62801e9 [PM-1906] check value of KeyValuePair for null instead of object

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Core/Services/PolicyService.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We are now updating the vault timeout information from new policies that come in from a sync. During this, I checked the existence of a MaximumVaultTimeout policy using .Equals(default), but this didn't seem to actually check the values for null.

I have now changed it to check the Value of the KeyValuePair for null instead.

Will need to be cherry-picked to rc

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2489 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 4/21/2023 **Status:** ✅ Merged **Merged:** 4/21/2023 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `pm-1906-sync-failing-policies` --- ### 📝 Commits (1) - [`62801e9`](https://github.com/bitwarden/android/commit/62801e9338aed07e4f8459bb08df47ec81da8bca) [PM-1906] check value of KeyValuePair for null instead of object ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/PolicyService.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> We are now updating the vault timeout information from new policies that come in from a sync. During this, I checked the existence of a `MaximumVaultTimeout` policy using `.Equals(default)`, but this didn't seem to actually check the values for null. I have now changed it to check the Value of the `KeyValuePair` for null instead. Will need to be cherry-picked to `rc` ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3591
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?