github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 17:14:25 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

New Mozilla browsers on Android need autofill whitelisting #359

New Issue
Closed
opened 2025-11-07 08:36:55 -06:00 by GiteaMirror · 11 comments
GiteaMirror commented 2025-11-07 08:36:55 -06:00
Owner
Copy Link

Originally created by @callahad on GitHub (Mar 27, 2019).

Hi Kyle, thanks for Bitwarden!

We have a few Android browser projects under development that need whitelisting in the autofill service:

  • org.mozilla.fenix
  • org.mozilla.reference.browser
  • org.mozilla.rocket

All support native Oreo/Pie autofill.

(See also: https://bugzil.la/1538385)

Originally created by @callahad on GitHub (Mar 27, 2019). Hi Kyle, thanks for Bitwarden! We have a few Android browser projects under development that need whitelisting in the autofill service: - `org.mozilla.fenix` - `org.mozilla.reference.browser` - `org.mozilla.rocket` All support native Oreo/Pie autofill. *(See also: https://bugzil.la/1538385)*
GiteaMirror commented 2025-11-07 08:36:56 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Mar 27, 2019):

Any idea if these work with the compat shim or "natively" with Pie autofill?

@kspearrin commented on GitHub (Mar 27, 2019): Any idea if these work with the compat shim or "natively" with Pie autofill?
GiteaMirror commented 2025-11-07 08:36:56 -06:00
Author
Owner
Copy Link

@makotokato commented on GitHub (Mar 29, 2019):

GeckoView based browsers (org.mozilla.fenix and org.mozilla.reference.browser) are same implementation as Firefox/Android.

Any idea if these work with the compat shim or "natively" with Pie autofill?

What's "natively" meant? Current Gecko supports Android O/P's auto fill framework.

@makotokato commented on GitHub (Mar 29, 2019): GeckoView based browsers (`org.mozilla.fenix` and `org.mozilla.reference.browser`) are same implementation as Firefox/Android. > Any idea if these work with the compat shim or "natively" with Pie autofill? What's "natively" meant? Current Gecko supports Android O/P's auto fill framework.
GiteaMirror commented 2025-11-07 08:36:57 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Mar 29, 2019):

As far as I know, Gecko uses the compatibility mode of the Autofill Framework. https://developer.android.com/reference/android/service/autofill/AutofillService.html#CompatibilityMode

@kspearrin commented on GitHub (Mar 29, 2019): As far as I know, Gecko uses the compatibility mode of the Autofill Framework. https://developer.android.com/reference/android/service/autofill/AutofillService.html#CompatibilityMode
GiteaMirror commented 2025-11-07 08:36:57 -06:00
Author
Owner
Copy Link

@makotokato commented on GitHub (Mar 29, 2019):

Firefox 63+ starts native API implementation by https://bugzilla.mozilla.org/show_bug.cgi?id=1330257. So at least, org.mozilla.fenix and org.mozilla.reference.browser should be added to CompatBrowsers list due to same implementation.

@makotokato commented on GitHub (Mar 29, 2019): Firefox 63+ starts native API implementation by https://bugzilla.mozilla.org/show_bug.cgi?id=1330257. So at least, `org.mozilla.fenix` and `org.mozilla.reference.browser` should be added to `CompatBrowsers` list due to same implementation.
GiteaMirror commented 2025-11-07 08:36:57 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Mar 29, 2019):

Feel free to try this fix with the APKs built here: https://ci.appveyor.com/project/bitwarden/mobile/build/artifacts

@kspearrin commented on GitHub (Mar 29, 2019): Feel free to try this fix with the APKs built here: https://ci.appveyor.com/project/bitwarden/mobile/build/artifacts
GiteaMirror commented 2025-11-07 08:36:58 -06:00
Author
Owner
Copy Link

@callahad commented on GitHub (Mar 30, 2019):

I can confirm that the in-app prompts work correctly with that APK, including properly filtering suggestions, and with the accessibility service disabled. Thank you!

If I enable the accessibility service, I get a system-wide autofill notification when password fields are focused. Tapping on that notification takes me to Bitwarden, but with entries filtered on the package name (org.mozilla.fenix) instead of the site URL. Selecting an entry does correctly autofill it.

Is that something that can be fixed, or is it an necessary quirk of Android's autofill implementation?

@callahad commented on GitHub (Mar 30, 2019): I can confirm that the in-app prompts work correctly with that APK, including properly filtering suggestions, and with the accessibility service disabled. Thank you! If I enable the accessibility service, I get a system-wide autofill notification when password fields are focused. Tapping on that notification takes me to Bitwarden, but with entries filtered on the package name (`org.mozilla.fenix`) instead of the site URL. Selecting an entry does correctly autofill it. Is that something that can be fixed, or is it an necessary quirk of Android's autofill implementation?
GiteaMirror commented 2025-11-07 08:36:58 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Mar 30, 2019):

@callahad I'll need to add it to the supported browser list for the accessibility service, seen here:
https://github.com/bitwarden/mobile/blob/master/src/Android/AutofillService.cs#L28

For this, I need to know the id of the view element that contains the URL of the current website you are viewing. For example, on Firefox stable, this is url_bar_title. Is the view id the same on these versions? If you don't know I can try to look them up myself if you tell me how I can download these apps.

@kspearrin commented on GitHub (Mar 30, 2019): @callahad I'll need to add it to the supported browser list for the accessibility service, seen here: https://github.com/bitwarden/mobile/blob/master/src/Android/AutofillService.cs#L28 For this, I need to know the id of the view element that contains the URL of the current website you are viewing. For example, on Firefox stable, this is `url_bar_title`. Is the view id the same on these versions? If you don't know I can try to look them up myself if you tell me how I can download these apps.
GiteaMirror commented 2025-11-07 08:36:59 -06:00
Author
Owner
Copy Link

@callahad commented on GitHub (Mar 31, 2019):

@agi90, can you answer the above for Fenix and Reference Browser?

@kspearrin: You grab nightly builds from Taskcluster: Fenix, Reference Browser.

The source for these projects lives at mozilla-mobile/fenix and mozilla-mobile/reference-browser, respectively.

@callahad commented on GitHub (Mar 31, 2019): @agi90, can you answer the above for Fenix and Reference Browser? @kspearrin: You grab nightly builds from Taskcluster: [Fenix](https://tools.taskcluster.net/index/project.mobile.fenix.signed-nightly.nightly/latest), [Reference Browser](https://tools.taskcluster.net/index/project.mobile.reference-browser.signed-nightly.nightly/latest). The source for these projects lives at [mozilla-mobile/fenix](https://github.com/mozilla-mobile/fenix/) and [mozilla-mobile/reference-browser](https://github.com/mozilla-mobile/reference-browser), respectively.
GiteaMirror commented 2025-11-07 08:36:59 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Apr 1, 2019):

@callahad For whatever reason, I can't open any of those APK files on my test device or Windows emulator. They just say "Can't open file" after downloading them in Chrome. Normally I can sideload apks without issue, so I am not sure what the problem is here.

@kspearrin commented on GitHub (Apr 1, 2019): @callahad For whatever reason, I can't open any of those APK files on my test device or Windows emulator. They just say "Can't open file" after downloading them in Chrome. Normally I can sideload apks without issue, so I am not sure what the problem is here.
GiteaMirror commented 2025-11-07 08:36:59 -06:00
Author
Owner
Copy Link

@colintheshots commented on GitHub (Apr 1, 2019):

I believe both Fenix and the Reference Browser use the BrowserToolbar Android Component. This means they use a view ID of mozac_browser_toolbar_edit_url_view for editing and mozac_browser_toolbar_url_view for viewing. Both views are always present, but only one is visible.

@colintheshots commented on GitHub (Apr 1, 2019): I believe both Fenix and the Reference Browser use the BrowserToolbar Android Component. This means they use a view ID of mozac_browser_toolbar_edit_url_view for editing and mozac_browser_toolbar_url_view for viewing. Both views are always present, but only one is visible.
GiteaMirror commented 2025-11-07 08:37:00 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Apr 1, 2019):

@callahad Feel free to try latest dev APK here now for accessibility service support: https://ci.appveyor.com/project/bitwarden/mobile/build/artifacts

I added mozac_browser_toolbar_url_view as the view id for both fenix and reference.

@kspearrin commented on GitHub (Apr 1, 2019): @callahad Feel free to try latest dev APK here now for accessibility service support: https://ci.appveyor.com/project/bitwarden/mobile/build/artifacts I added `mozac_browser_toolbar_url_view` as the view id for both fenix and reference.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?