github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2474] [MERGED] [PS-2507] Enable firefox relay address on creation #3586

New Issue
Closed
opened 2025-11-26 23:34:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2474
Author: @djsmith85
Created: 4/13/2023
Status: ✅ Merged
Merged: 4/14/2023
Merged by: @djsmith85

Base: master ← Head: PS-2507-generating-firefox-relay-address-set-to-block

📝 Commits (3)

  • 7b19431 Enable firefox relay address on creation
  • dae7710 Add missing encoding and mediaType
  • 2279088 Replace JObject with anonymous type

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 src/Core/Services/ApiService.cs (+6 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes https://github.com/bitwarden/mobile/issues/2375
Enable firefox relay address on creation

Adding a body (json) to the request and setting enabled to true. Additionally the description is set to "Generated by Bitwarden." to mimick the behaviour of the other clients

Code changes

  • src/Core/Services/ApiService.cs: Added payload to request when creating a username via FireFox Relay - Details of the payload was taken from the JS-clients

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2474 **Author:** [@djsmith85](https://github.com/djsmith85) **Created:** 4/13/2023 **Status:** ✅ Merged **Merged:** 4/14/2023 **Merged by:** [@djsmith85](https://github.com/djsmith85) **Base:** `master` ← **Head:** `PS-2507-generating-firefox-relay-address-set-to-block` --- ### 📝 Commits (3) - [`7b19431`](https://github.com/bitwarden/android/commit/7b1943188c595bd98d9afd24f793cd99b88794ac) Enable firefox relay address on creation - [`dae7710`](https://github.com/bitwarden/android/commit/dae7710944600e5ed855a5b397b3d8cbd842edfa) Add missing encoding and mediaType - [`2279088`](https://github.com/bitwarden/android/commit/22790887146898ced2e622fe4edfa1c73db47004) Replace JObject with anonymous type ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/ApiService.cs` (+6 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fixes https://github.com/bitwarden/mobile/issues/2375 Enable firefox relay address on creation Adding a body (json) to the request and setting enabled to true. Additionally the description is set to "Generated by Bitwarden." to mimick the behaviour of the other clients ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/Core/Services/ApiService.cs:** Added payload to request when creating a username via FireFox Relay - Details of the payload was taken from the [JS-clients](https://github.com/bitwarden/clients/blob/b3d4d9898e0eb196e872501246c1856ccdcbf993/libs/common/src/tools/generator/username/email-forwarders/firefox-relay-forwarder.ts#L21) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3586
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?