github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2473] [CLOSED] [Mobile Automation] Adding automationID on mobile elements #3585

New Issue
Closed
opened 2025-11-26 23:34:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2473
Author: @ifernandezdiaz
Created: 4/13/2023
Status: ❌ Closed

Base: master ← Head: automation/adding-ids-to-elements

📝 Commits (3)

  • 5f8c972 Adding locators for Environment, Hope, Login and Register pages
  • 3462445 Merge branch 'master' into automation/adding-ids-to-elements
  • 1636227 Adding Locators on LockPage

📊 Changes

5 files changed (+70 additions, -33 deletions)

View changed files

📝 src/App/Pages/Accounts/EnvironmentPage.xaml (+10 -5)
📝 src/App/Pages/Accounts/HomePage.xaml (+13 -6)
📝 src/App/Pages/Accounts/LockPage.xaml (+11 -5)
📝 src/App/Pages/Accounts/LoginPage.xaml (+21 -10)
📝 src/App/Pages/Accounts/RegisterPage.xaml (+15 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

To improve the reliability of our mobile automated tests, we started to add AutomationIDs for the most important elements in our mobile app.
This branch will be not merged to master for now. It will be updated regularly with the latest updates. Once we finish with the locators, we can discuss if we can merge the changes to master or not.
NOTE: We should run a regression suite to confirm accessibility is not broken for these updates

Code changes

Adding AutomationIDs labels for every element we interact in our automated tests.

Screenshots

Screenshot 2023-04-13 at 14 14 56

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2473 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 4/13/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `automation/adding-ids-to-elements` --- ### 📝 Commits (3) - [`5f8c972`](https://github.com/bitwarden/android/commit/5f8c97214a9f5a8a514a0ac8dcf580f653269bcc) Adding locators for Environment, Hope, Login and Register pages - [`3462445`](https://github.com/bitwarden/android/commit/3462445586fd1c2ffeef121c3584f9fd20d94172) Merge branch 'master' into automation/adding-ids-to-elements - [`1636227`](https://github.com/bitwarden/android/commit/1636227a9cfcaadaa63e4cc57008c557b9d4ba47) Adding Locators on LockPage ### 📊 Changes **5 files changed** (+70 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/EnvironmentPage.xaml` (+10 -5) 📝 `src/App/Pages/Accounts/HomePage.xaml` (+13 -6) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+11 -5) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+21 -10) 📝 `src/App/Pages/Accounts/RegisterPage.xaml` (+15 -7) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective To improve the reliability of our mobile automated tests, we started to add `AutomationIDs` for the most important elements in our `mobile` app. This branch will be not merged to `master` for now. It will be updated regularly with the latest updates. Once we finish with the locators, we can discuss if we can merge the changes to `master` or not. NOTE: We should run a regression suite to confirm accessibility is not broken for these updates ## Code changes Adding `AutomationIDs` labels for every element we interact in our automated tests. ## Screenshots ![Screenshot 2023-04-13 at 14 14 56](https://user-images.githubusercontent.com/23522800/231835197-fa313de1-2311-4d8d-a26e-afc1972ce644.png) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3585
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?