github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2463] [MERGED] [PM-1690] Added minimum server version restriction to cipher key encryption #3580

New Issue
Closed
opened 2025-11-26 23:34:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2463
Author: @fedemkr
Created: 4/5/2023
Status: ✅ Merged
Merged: 5/23/2023
Merged by: @fedemkr

Base: feature/PM-115-encryption-update-new-model ← Head: PM-1690-restriction-cipher-key-server-version

📝 Commits (5)

  • b8da2e4 PM-1690 added minimum server version restriction to cipher key encryption and also change the force key rotation flag
  • 18fe1d0 Merge branch 'master' into PM-1690-restriction-cipher-key-server-version
  • 148ca16 PM-1690 Updated min server version for new cipher encryption key and fixed configService registration
  • 04ac9f2 Merge branch 'feature/PM-115-encryption-update-new-model' into PM-1690-restriction-cipher-key-server-version
  • b3349f8 PM-1690 removed forcekeyrotation

📊 Changes

4 files changed (+56 additions, -3 deletions)

View changed files

📝 src/Core/Constants.cs (+1 -0)
📝 src/Core/Services/CipherService.cs (+18 -0)
📝 src/Core/Utilities/ServiceContainer.cs (+3 -3)
➕ src/Core/Utilities/VersionHelpers.cs (+34 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add minimum server version restriction to cipher key encryption usage.

Code changes

  • Constants: Added constant to indicate the minimum server version in which the cipher key encryption is available.
  • CipherService: Added server version check to perform the cipher key encryption only if the server has the feature available.
  • VersionHelpers: Added some helpers methods to compare server versions without taking into account the hotfix suffix.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2463 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/5/2023 **Status:** ✅ Merged **Merged:** 5/23/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/PM-115-encryption-update-new-model` ← **Head:** `PM-1690-restriction-cipher-key-server-version` --- ### 📝 Commits (5) - [`b8da2e4`](https://github.com/bitwarden/android/commit/b8da2e47930d60ffeb2ef138519035ed02858379) PM-1690 added minimum server version restriction to cipher key encryption and also change the force key rotation flag - [`18fe1d0`](https://github.com/bitwarden/android/commit/18fe1d025290b0a3d0a4bb0f5dfd2a50c2f19d75) Merge branch 'master' into PM-1690-restriction-cipher-key-server-version - [`148ca16`](https://github.com/bitwarden/android/commit/148ca16187c56bc8a6ba4a4092822e2dbcfe8caf) PM-1690 Updated min server version for new cipher encryption key and fixed configService registration - [`04ac9f2`](https://github.com/bitwarden/android/commit/04ac9f22936ccebf81f8541c382becbed39929a3) Merge branch 'feature/PM-115-encryption-update-new-model' into PM-1690-restriction-cipher-key-server-version - [`b3349f8`](https://github.com/bitwarden/android/commit/b3349f807126920350db7659e1ed5fa3300048cb) PM-1690 removed forcekeyrotation ### 📊 Changes **4 files changed** (+56 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Constants.cs` (+1 -0) 📝 `src/Core/Services/CipherService.cs` (+18 -0) 📝 `src/Core/Utilities/ServiceContainer.cs` (+3 -3) ➕ `src/Core/Utilities/VersionHelpers.cs` (+34 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add minimum server version restriction to cipher key encryption usage. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Constants:** Added constant to indicate the minimum server version in which the cipher key encryption is available. * **CipherService:** Added server version check to perform the cipher key encryption only if the server has the feature available. * **VersionHelpers:** Added some helpers methods to compare server versions without taking into account the hotfix suffix. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3580
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?