github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2454] [MERGED] [PM-190] Add Environments to mobile login/registration #3573

New Issue
Closed
opened 2025-11-26 23:34:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2454
Author: @andrebispo5
Created: 3/29/2023
Status: ✅ Merged
Merged: 4/4/2023
Merged by: @andrebispo5

Base: feature/pm-1351-get-feature-flags ← Head: auth/pm-190-environments

📝 Commits (10+)

  • b814c5e [PM-190] Add US EU environment base urls. Add env picker to the HomePage. Remove cog icon from HomePage. Add env description to LoginPage.
  • c95caee Merge branch 'feature/pm-1351-get-feature-flags' into auth/pm-190-environments
  • 7431dd1 [PM-190] Added conditional add of EU server.
  • 4395ff2 Code format
  • 09b152b Merge branch 'feature/pm-1351-get-feature-flags' into auth/pm-190-environments
  • 5130fff Merge branch 'feature/pm-1351-get-feature-flags' into auth/pm-190-environments
  • 8fd5808 [PM-190] PR Fixes
  • 3d0d8bf code format
  • cba21b5 [PM-190] Remove equals
  • 6392fa3 [PM-190] PR fixes

📊 Changes

12 files changed (+222 additions, -27 deletions)

View changed files

📝 src/App/Pages/Accounts/EnvironmentPageViewModel.cs (+3 -1)
📝 src/App/Pages/Accounts/HomePage.xaml (+21 -5)
📝 src/App/Pages/Accounts/HomePage.xaml.cs (+10 -8)
📝 src/App/Pages/Accounts/HomePageViewModel.cs (+72 -4)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+13 -1)
📝 src/App/Resources/AppResources.Designer.cs (+48 -3)
📝 src/App/Resources/AppResources.resx (+17 -2)
📝 src/Core/Abstractions/IConfigService.cs (+4 -1)
📝 src/Core/Models/Data/EnvironmentUrlData.cs (+11 -0)
📝 src/Core/Models/Response/ConfigResponse.cs (+2 -0)
📝 src/Core/Services/ConfigService.cs (+21 -1)
📝 src/Core/Services/StateService.cs (+0 -1)

📄 Description

Merged after https://github.com/bitwarden/mobile/pull/2431

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Provide the user the ability to change the environment into which he is logging in or creating an account.
The selected environment should persist when a user logs out.
EU environment shows based on feature flag.
Environment settings cog, on top right corner of the HomePage was moved to the environment picker as self-host.

Code changes

  • src/App/Pages/Accounts/HomePage.xaml.cs: UpdateEnvironment added in OnAppearing is used to update the environment selector label when the user comes from the self-hosted screen back to the HomePage

Screenshots

Screenshot 2023-03-28 at 15 40 57 Screenshot 2023-03-28 at 17 01 35 Screenshot 2023-03-28 at 15 53 23

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2454 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 3/29/2023 **Status:** ✅ Merged **Merged:** 4/4/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/pm-1351-get-feature-flags` ← **Head:** `auth/pm-190-environments` --- ### 📝 Commits (10+) - [`b814c5e`](https://github.com/bitwarden/android/commit/b814c5ed48c41226c58506c3dfffc0608e6ceb3e) [PM-190] Add US EU environment base urls. Add env picker to the HomePage. Remove cog icon from HomePage. Add env description to LoginPage. - [`c95caee`](https://github.com/bitwarden/android/commit/c95caee273d8b3d16fab4ce9d8d2c9cd638a2ab2) Merge branch 'feature/pm-1351-get-feature-flags' into auth/pm-190-environments - [`7431dd1`](https://github.com/bitwarden/android/commit/7431dd1aaf894b76d8c6b20aac339da2cf8c4ce9) [PM-190] Added conditional add of EU server. - [`4395ff2`](https://github.com/bitwarden/android/commit/4395ff268e932222b8c7fc26ca048b9c4e716093) Code format - [`09b152b`](https://github.com/bitwarden/android/commit/09b152b3976848751de241fb067eb0588f0c2bab) Merge branch 'feature/pm-1351-get-feature-flags' into auth/pm-190-environments - [`5130fff`](https://github.com/bitwarden/android/commit/5130fff3ee24367ed6221ab78a50cc7f50951ad6) Merge branch 'feature/pm-1351-get-feature-flags' into auth/pm-190-environments - [`8fd5808`](https://github.com/bitwarden/android/commit/8fd5808b3ca78da9ac3c1e486a500956080eef12) [PM-190] PR Fixes - [`3d0d8bf`](https://github.com/bitwarden/android/commit/3d0d8bfec5ec6cfe94a17093dead6e782790a87f) code format - [`cba21b5`](https://github.com/bitwarden/android/commit/cba21b54f460c79f31e829fa2d69cc5b05fa8811) [PM-190] Remove equals - [`6392fa3`](https://github.com/bitwarden/android/commit/6392fa3d1378f23e3159f6d3cc68617e45ad5138) [PM-190] PR fixes ### 📊 Changes **12 files changed** (+222 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/EnvironmentPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Accounts/HomePage.xaml` (+21 -5) 📝 `src/App/Pages/Accounts/HomePage.xaml.cs` (+10 -8) 📝 `src/App/Pages/Accounts/HomePageViewModel.cs` (+72 -4) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+13 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+48 -3) 📝 `src/App/Resources/AppResources.resx` (+17 -2) 📝 `src/Core/Abstractions/IConfigService.cs` (+4 -1) 📝 `src/Core/Models/Data/EnvironmentUrlData.cs` (+11 -0) 📝 `src/Core/Models/Response/ConfigResponse.cs` (+2 -0) 📝 `src/Core/Services/ConfigService.cs` (+21 -1) 📝 `src/Core/Services/StateService.cs` (+0 -1) </details> ### 📄 Description Merged after https://github.com/bitwarden/mobile/pull/2431 ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Provide the user the ability to change the environment into which he is logging in or creating an account. The selected environment should persist when a user logs out. EU environment shows based on feature flag. Environment settings cog, on top right corner of the `HomePage` was moved to the environment picker as self-host. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/App/Pages/Accounts/HomePage.xaml.cs:** `UpdateEnvironment` added in `OnAppearing` is used to update the environment selector label when the user comes from the self-hosted screen back to the `HomePage` ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="400" alt="Screenshot 2023-03-28 at 15 40 57" src="https://user-images.githubusercontent.com/4648522/228469297-42bb1f8d-09e1-4d75-9f9b-54071a23db9e.png"> <img width="400" alt="Screenshot 2023-03-28 at 17 01 35" src="https://user-images.githubusercontent.com/4648522/228469395-215b9629-de60-42f0-b611-72eb41b0438d.png"> <img width="400" alt="Screenshot 2023-03-28 at 15 53 23" src="https://user-images.githubusercontent.com/4648522/228469364-e4dcdd1c-f649-4872-95e9-b8b4a8f00605.png"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3573
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?