github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 08:36:09 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #4787] [MERGED] PM-18636 Hide coach mark card if any login ciphers exist #35712

New Issue
Closed
opened 2026-04-21 03:03:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 03:03:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4787
Author: @dseverns-livefront
Created: 2/26/2025
Status: ✅ Merged
Merged: 2/26/2025
Merged by: @phil-livefront

Base: main ← Head: PM-18636-showcoachmark-conditions

📝 Commits (4)

  • 0aeba02 PM-18636 should only show the coachmark cards if no login ciphers exist in the vault
  • b40b39e Update app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt
  • b5a85c4 PR comments
  • 3cc1690 Merge branch 'main' into PM-18636-showcoachmark-conditions

📊 Changes

2 files changed (+87 additions, -5 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt (+21 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt (+66 -5)

📄 Description

🎟️ Tracking

PM-18636

📔 Objective

  • To avoid showing the coach mark cards to users who have been using the app and are familiar we are adding a business rule to avoid showing the card if there is any LOGIN type ciphers in the user's vault.

📸 Screenshots

https://github.com/user-attachments/assets/a7099cd4-18e3-4bc7-b010-4ec29f32a9ac

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4787 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 2/26/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `PM-18636-showcoachmark-conditions` --- ### 📝 Commits (4) - [`0aeba02`](https://github.com/bitwarden/android/commit/0aeba0224662b4e3b58d7eb9b24c6538f685cf02) PM-18636 should only show the coachmark cards if no login ciphers exist in the vault - [`b40b39e`](https://github.com/bitwarden/android/commit/b40b39eb38d73c891487e1756b3aca1eb54eeac3) Update app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt - [`b5a85c4`](https://github.com/bitwarden/android/commit/b5a85c440c93f7d4332813719964411b255dddee) PR comments - [`3cc1690`](https://github.com/bitwarden/android/commit/3cc169009619c2b73f48b60e68f299ce99acf189) Merge branch 'main' into PM-18636-showcoachmark-conditions ### 📊 Changes **2 files changed** (+87 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt` (+21 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt` (+66 -5) </details> ### 📄 Description ## 🎟️ Tracking [PM-18636](https://bitwarden.atlassian.net/browse/PM-18636) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - To avoid showing the coach mark cards to users who have been using the app and are familiar we are adding a business rule to avoid showing the card if there is any LOGIN type ciphers in the user's vault. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/a7099cd4-18e3-4bc7-b010-4ec29f32a9ac <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18636]: https://bitwarden.atlassian.net/browse/PM-18636?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 03:03:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#35712
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?