github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4694] [MERGED] [PM-11886] Update handling of unprivileged apps and improve error messaging #35633

New Issue
Closed
opened 2026-04-21 02:59:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:59:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4694
Author: @SaintPatrck
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-11886/update-origin-for-unprivileged-apps

📝 Commits (10+)

  • dd31e4f [PM-11886] Update handling of unprivileged apps and improve error messaging
  • 962de84 Skip tests for now
  • 4cc3bf3 Log UV and generic error references for better tracing
  • d9601b3 Write passkey logs to disk and copy to clipboard from settings > about
  • 2b355f7 Log fido2GetCredentialsRequest in VaultItemListingViewModel
  • b89eaf0 More passkey-related logging for debugging
  • 3448fe7 Log exceptions when decoding passkey attestation or assertion options
  • 17f2236 Fix tests
  • 95e1bfd Check for GetCreds request when dismissing FIDO2 dialog
  • 6be3fc3 Make transports optional in PublicKeyCredentialDescriptor

📊 Changes

26 files changed (+569 additions, -340 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt (+82 -47)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManager.kt (+0 -9)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManagerImpl.kt (+4 -20)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionResult.kt (+3 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsResult.kt (+4 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2RegisterCredentialResult.kt (+4 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PublicKeyCredentialDescriptor.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt (+63 -63)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt (+14 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt (+6 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+11 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+9 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+5 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+103 -61)
📝 app/src/main/res/values/strings.xml (+13 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt (+36 -44)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt (+96 -9)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt (+12 -4)

...and 6 more files

📄 Description

🎟️ Tracking

PM-11886
Resolves #4239

📔 Objective

Improve passkey processing with unprivileged applications and provide more descriptive error messages when failures occur.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4694 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-11886/update-origin-for-unprivileged-apps` --- ### 📝 Commits (10+) - [`dd31e4f`](https://github.com/bitwarden/android/commit/dd31e4fc1423aaed839a3a7ca2c56cf55568c163) [PM-11886] Update handling of unprivileged apps and improve error messaging - [`962de84`](https://github.com/bitwarden/android/commit/962de84eeafe4fe991dd8ffc6cecc2c2a9267c90) Skip tests for now - [`4cc3bf3`](https://github.com/bitwarden/android/commit/4cc3bf399a2abc19d7276a78d617475800b1b1bd) Log UV and generic error references for better tracing - [`d9601b3`](https://github.com/bitwarden/android/commit/d9601b3023e51a0eb4cb57a304d800e14ff47bd1) Write passkey logs to disk and copy to clipboard from settings > about - [`2b355f7`](https://github.com/bitwarden/android/commit/2b355f721f2d01e081bb59857d1ef96b1da95b2d) Log `fido2GetCredentialsRequest` in `VaultItemListingViewModel` - [`b89eaf0`](https://github.com/bitwarden/android/commit/b89eaf05da4028072dbd7e06cf73c2ff424ccaee) More passkey-related logging for debugging - [`3448fe7`](https://github.com/bitwarden/android/commit/3448fe75712d5b49886995a8063ba7908b194395) Log exceptions when decoding passkey attestation or assertion options - [`17f2236`](https://github.com/bitwarden/android/commit/17f22369b6e892a4e4c601e1f59547ed9a2142ef) Fix tests - [`95e1bfd`](https://github.com/bitwarden/android/commit/95e1bfdba89145a6e89ef4b885f920e936a1696a) Check for GetCreds request when dismissing FIDO2 dialog - [`6be3fc3`](https://github.com/bitwarden/android/commit/6be3fc30b5565ea83c67c16e11ae4c9ae9d56a44) Make `transports` optional in `PublicKeyCredentialDescriptor` ### 📊 Changes **26 files changed** (+569 additions, -340 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt` (+82 -47) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManager.kt` (+0 -9) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManagerImpl.kt` (+4 -20) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionResult.kt` (+3 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsResult.kt` (+4 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2RegisterCredentialResult.kt` (+4 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PublicKeyCredentialDescriptor.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt` (+63 -63) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt` (+14 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt` (+6 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+11 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+9 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+5 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+103 -61) 📝 `app/src/main/res/values/strings.xml` (+13 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt` (+36 -44) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt` (+96 -9) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt` (+12 -4) _...and 6 more files_ </details> ### 📄 Description ## 🎟️ Tracking PM-11886 Resolves #4239 ## 📔 Objective Improve passkey processing with unprivileged applications and provide more descriptive error messages when failures occur. ## 📸 Screenshots Coming soon! ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:59:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#35633
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?