github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2418] [MERGED] [PM-1497] Known device api error #3556

New Issue
Closed
opened 2025-11-26 23:34:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2418
Author: @andrebispo5
Created: 3/16/2023
Status: ✅ Merged
Merged: 3/17/2023
Merged by: @andrebispo5

Base: master ← Head: bugfix/pm-1497-fail-known-device

📝 Commits (4)

  • 3357a1e [PM-1497] Ignore know device api error.
  • 1051e9b [PM-1497] Code format
  • 7b6ed73 Merge branch 'master' into bugfix/pm-1497-fail-known-device
  • 111d4a8 [PM-1497] refactor

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+9 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Ignore Know Device api endpoint error on mobile.

Code changes

  • Check for api 401 error and silently log the exception instead of showing an error dialog
  • Moved the hide loading to finally block.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2418 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 3/16/2023 **Status:** ✅ Merged **Merged:** 3/17/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/pm-1497-fail-known-device` --- ### 📝 Commits (4) - [`3357a1e`](https://github.com/bitwarden/android/commit/3357a1e6332a2bd480d9079caa502597f15431fc) [PM-1497] Ignore know device api error. - [`1051e9b`](https://github.com/bitwarden/android/commit/1051e9b9e9ccd34eaaede9ef2728b51c93101d1f) [PM-1497] Code format - [`7b6ed73`](https://github.com/bitwarden/android/commit/7b6ed73fdee5fe456ca27d76ec054dd30c8643d6) Merge branch 'master' into bugfix/pm-1497-fail-known-device - [`111d4a8`](https://github.com/bitwarden/android/commit/111d4a8093efad634c3bd88a08acda9b1337bd92) [PM-1497] refactor ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+9 -3) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Ignore Know Device api endpoint error on mobile. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> - Check for api 401 error and silently log the exception instead of showing an error dialog - Moved the hide loading to finally block. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3556
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?