github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2409] [MERGED] [PM-1129] iOS 16 Third-Party 2FA OTP handling #3549

New Issue
Closed
opened 2025-11-26 23:34:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2409
Author: @fedemkr
Created: 3/9/2023
Status: ✅ Merged
Merged: 3/9/2023
Merged by: @fedemkr

Base: master ← Head: feature/EC-979-iOS-third-party-2fa

📝 Commits (8)

  • 4896618 [EC-980] Added iOS otpauth handler (#2370)
  • ce94560 Merge branch 'master' into feature/EC-979-iOS-third-party-2fa
  • d712fe7 Merge branch 'master' into feature/EC-979-iOS-third-party-2fa
  • 04d2002 [EC-981] OTP handling - Set to selected cipher (#2404)
  • 46b330b Merge branch 'master' into feature/EC-979-iOS-third-party-2fa
  • 5480cb7 PM-1131 implemented cipher creation from otp handling flow with otp key filled (#2407)
  • 01a1f25 Merge branch 'master' into feature/EC-979-iOS-third-party-2fa
  • 3f26765 PM-1133 Updated empty states for search and cipher selection on otp flow (#2408)

📊 Changes

34 files changed (+1223 additions, -576 deletions)

View changed files

📝 src/Android/MainActivity.cs (+4 -4)
📝 src/App/Abstractions/IAccountsManager.cs (+1 -0)
➕ src/App/Abstractions/IDeepLinkContext.cs (+9 -0)
📝 src/App/App.xaml.cs (+28 -11)
📝 src/App/Models/AppOptions.cs (+3 -0)
📝 src/App/Pages/Vault/AutofillCiphersPageViewModel.cs (+65 -164)
📝 src/App/Pages/Vault/CipherAddEditPageViewModel.cs (+23 -0)
📝 src/App/Pages/Vault/CipherSelectionPage.xaml (+47 -14)
📝 src/App/Pages/Vault/CipherSelectionPage.xaml.cs (+50 -22)
➕ src/App/Pages/Vault/CipherSelectionPageViewModel.cs (+167 -0)
📝 src/App/Pages/Vault/CiphersPage.xaml (+16 -6)
📝 src/App/Pages/Vault/CiphersPage.xaml.cs (+9 -5)
📝 src/App/Pages/Vault/CiphersPageViewModel.cs (+62 -19)
➕ src/App/Pages/Vault/OTPCipherSelectionPageViewModel.cs (+79 -0)
📝 src/App/Resources/AppResources.Designer.cs (+40 -7)
📝 src/App/Resources/AppResources.resx (+12 -0)
➕ src/App/Services/DeepLinkContext.cs (+30 -0)
📝 src/App/Utilities/AccountManagement/AccountsManager.cs (+11 -1)
📝 src/App/Utilities/AppHelpers.cs (+4 -2)
📝 src/App/Utilities/AppSetup.cs (+4 -1)

...and 14 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This adds OTP handling feature to iOS and adds Bitwarden app as a 2FA option for the iOS platform.

This PR is the combination of several other ones that have already been reviewed and approved:
#2370
#2404
#2407
#2408

Code changes

Check the other PRs aforementioned

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2409 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/9/2023 **Status:** ✅ Merged **Merged:** 3/9/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `feature/EC-979-iOS-third-party-2fa` --- ### 📝 Commits (8) - [`4896618`](https://github.com/bitwarden/android/commit/4896618e1c974c53b72870d6e1ee75edd101ada7) [EC-980] Added iOS otpauth handler (#2370) - [`ce94560`](https://github.com/bitwarden/android/commit/ce94560da064764acfa00ac849a0391ab53111a3) Merge branch 'master' into feature/EC-979-iOS-third-party-2fa - [`d712fe7`](https://github.com/bitwarden/android/commit/d712fe7da69d6eac1652eca96779a6be67aa6285) Merge branch 'master' into feature/EC-979-iOS-third-party-2fa - [`04d2002`](https://github.com/bitwarden/android/commit/04d20021e6a9a4f1b2ceb4f7558e4b52806f426e) [EC-981] OTP handling - Set to selected cipher (#2404) - [`46b330b`](https://github.com/bitwarden/android/commit/46b330bb03b3d2c0c21562e2c686e04a4648742a) Merge branch 'master' into feature/EC-979-iOS-third-party-2fa - [`5480cb7`](https://github.com/bitwarden/android/commit/5480cb7ff69de54e974929177681da5e1a1eaf6a) PM-1131 implemented cipher creation from otp handling flow with otp key filled (#2407) - [`01a1f25`](https://github.com/bitwarden/android/commit/01a1f2592e97f6fb8db3b7d00f3415cb436c15a6) Merge branch 'master' into feature/EC-979-iOS-third-party-2fa - [`3f26765`](https://github.com/bitwarden/android/commit/3f26765434e76c03d89ce40b81aa97b6a4778f35) PM-1133 Updated empty states for search and cipher selection on otp flow (#2408) ### 📊 Changes **34 files changed** (+1223 additions, -576 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+4 -4) 📝 `src/App/Abstractions/IAccountsManager.cs` (+1 -0) ➕ `src/App/Abstractions/IDeepLinkContext.cs` (+9 -0) 📝 `src/App/App.xaml.cs` (+28 -11) 📝 `src/App/Models/AppOptions.cs` (+3 -0) 📝 `src/App/Pages/Vault/AutofillCiphersPageViewModel.cs` (+65 -164) 📝 `src/App/Pages/Vault/CipherAddEditPageViewModel.cs` (+23 -0) 📝 `src/App/Pages/Vault/CipherSelectionPage.xaml` (+47 -14) 📝 `src/App/Pages/Vault/CipherSelectionPage.xaml.cs` (+50 -22) ➕ `src/App/Pages/Vault/CipherSelectionPageViewModel.cs` (+167 -0) 📝 `src/App/Pages/Vault/CiphersPage.xaml` (+16 -6) 📝 `src/App/Pages/Vault/CiphersPage.xaml.cs` (+9 -5) 📝 `src/App/Pages/Vault/CiphersPageViewModel.cs` (+62 -19) ➕ `src/App/Pages/Vault/OTPCipherSelectionPageViewModel.cs` (+79 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+40 -7) 📝 `src/App/Resources/AppResources.resx` (+12 -0) ➕ `src/App/Services/DeepLinkContext.cs` (+30 -0) 📝 `src/App/Utilities/AccountManagement/AccountsManager.cs` (+11 -1) 📝 `src/App/Utilities/AppHelpers.cs` (+4 -2) 📝 `src/App/Utilities/AppSetup.cs` (+4 -1) _...and 14 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This adds OTP handling feature to iOS and adds Bitwarden app as a 2FA option for the iOS platform. This PR is the combination of several other ones that have already been reviewed and approved: #2370 #2404 #2407 #2408 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Check the other PRs aforementioned ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3549
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?