github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 04:03:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2407] [MERGED] [PM-1131] OTP Handling - Create cipher with OTP filled #3547

New Issue
Closed
opened 2025-11-26 23:34:15 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:15 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2407
Author: @fedemkr
Created: 3/7/2023
Status: ✅ Merged
Merged: 3/8/2023
Merged by: @fedemkr

Base: feature/EC-979-iOS-third-party-2fa ← Head: feature/ios-third-party-2fa/PM-1131-create-cipher-with-otp

📝 Commits (1)

  • 66faf0a PM-1131 implemented cipher creation from otp handling flow with otp key filled

📊 Changes

5 files changed (+42 additions, -3 deletions)

View changed files

📝 src/App/Pages/Vault/AutofillCiphersPageViewModel.cs (+19 -0)
📝 src/App/Pages/Vault/CipherSelectionPage.xaml (+8 -2)
📝 src/App/Pages/Vault/CipherSelectionPage.xaml.cs (+1 -0)
📝 src/App/Pages/Vault/CipherSelectionPageViewModel.cs (+6 -0)
📝 src/App/Pages/Vault/OTPCipherSelectionPageViewModel.cs (+8 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

On the OTP handler flow, add the possibility to create a new login cipher with the OTP key already filled in.

Code changes

  • CipherSelectionPage.xaml / ...xaml.cs: Added "Add" toolbar item on iOS and changed click event handlers with commands on adding
  • CIpherSelectionPageViewModel: Added AddCommand and template method to implement it
  • AutofillCiphersPageViewModel: Moved add cipher implementation to this VM on the add command action
  • OTPCipherSelectionPageViewModel: Implemented add cipher with the otp data

Screenshots

Select cipher with add button

Select cipher with add button

Select cipher with add button (Dark)

Select cipher with add button dark

Add cipher from otp

Add cipher from otp

Add cipher from otp (Dark)

Add cipher from otp dark

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2407 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/7/2023 **Status:** ✅ Merged **Merged:** 3/8/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/EC-979-iOS-third-party-2fa` ← **Head:** `feature/ios-third-party-2fa/PM-1131-create-cipher-with-otp` --- ### 📝 Commits (1) - [`66faf0a`](https://github.com/bitwarden/android/commit/66faf0a0d2a048760992dc623ab0f2373406120c) PM-1131 implemented cipher creation from otp handling flow with otp key filled ### 📊 Changes **5 files changed** (+42 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AutofillCiphersPageViewModel.cs` (+19 -0) 📝 `src/App/Pages/Vault/CipherSelectionPage.xaml` (+8 -2) 📝 `src/App/Pages/Vault/CipherSelectionPage.xaml.cs` (+1 -0) 📝 `src/App/Pages/Vault/CipherSelectionPageViewModel.cs` (+6 -0) 📝 `src/App/Pages/Vault/OTPCipherSelectionPageViewModel.cs` (+8 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> On the OTP handler flow, add the possibility to create a new login cipher with the OTP key already filled in. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherSelectionPage.xaml / ...xaml.cs:** Added "Add" toolbar item on iOS and changed click event handlers with commands on adding * **CIpherSelectionPageViewModel:** Added `AddCommand` and template method to implement it * **AutofillCiphersPageViewModel:** Moved add cipher implementation to this VM on the add command action * **OTPCipherSelectionPageViewModel:** Implemented add cipher with the otp data ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### Select cipher with add button <img width="314" alt="Select cipher with add button" src="https://user-images.githubusercontent.com/15682323/223485607-e7755d8b-45d6-493a-b0d4-e59ecee173d3.PNG"> ### Select cipher with add button (Dark) <img width="314" alt="Select cipher with add button dark" src="https://user-images.githubusercontent.com/15682323/223485601-d7b0886d-8bd5-4a1a-b5a8-f502dda2f6d4.PNG"> ### Add cipher from otp <img width="314" alt="Add cipher from otp" src="https://user-images.githubusercontent.com/15682323/223485582-c854c2cb-a256-497e-bf99-e987c350444c.PNG"> ### Add cipher from otp (Dark) <img width="314" alt="Add cipher from otp dark" src="https://user-images.githubusercontent.com/15682323/223485594-ed413fa5-192d-472e-a6e2-3cddb53320b5.PNG"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3547
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?