github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2406] [CLOSED] Add refresh ability in autofill #3546

New Issue
Closed
opened 2025-11-26 23:34:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2406
Author: @pavelzw
Created: 3/7/2023
Status: ❌ Closed

Base: main ← Head: autofill-refresh

📝 Commits (10+)

  • e51233b Update README and CONTRIBUTING to use contributing.bitwarden.com (#1932)
  • 448758a Additional logic around filter display (#1951)
  • c53a85c [SG-390] Fix for missing org items with single org & personal ownership enabled (#1953)
  • 3aef86b [SG-386] iOS Update user state when coming from background (#1952)
  • f24388c separate init and showVaultFilter property set (#1954)
  • 7c311fb fix for missing personal items added prior to joining org with personal ownership policy (#1955)
  • b250055 SG-396 Fix tappable area after hiding account switching (#1956)
  • c892e9f Pin NuGet version (#1957)
  • 109aeb4 [BEEEP] [PS-940] Support for dark theme selection while using Default (System) theme (#1959)
  • 6e2e613 Add ssoToken to limit lifetime of SSO redirect (#1965)

📊 Changes

1 file changed (+19 additions, -12 deletions)

View changed files

📝 src/App/Pages/Vault/AutofillCiphersPage.xaml (+19 -12)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Closes #1710

This PR introduces the ability to pull to refresh in the autofill window like in the default app.

Since I am not able to run it in iOS, I didn't try it there... We probably still need to do some iOS specific stuff here... Any help is appreciated to try test it out there.
I tried out #1939 but unfortunately don't have an Apple Developer account. Works on iOS too.

cc @danstooamerican

Code changes

  • AutofillCiphersPageViewModel.cs: Add RefreshAsync()
  • AutofillCiphersPage.xaml Add RefreshView
  • LoginListViewController.cs Add RefreshControl_ActivatedAsync()
  • LoginListViewController.designer.cs Add RefreshControl_ActivatedAsync
  • iOS.Autofill/MainInterface.storyboard Add refreshControl
  • iOS.Core/Views Add RefreshAsync()

Screenshots

iOS

https://user-images.githubusercontent.com/29506042/224867225-fa3adfc1-3f42-4085-a30d-f90e3d98fd59.mov

Android

https://user-images.githubusercontent.com/29506042/224867273-dd5dd4cc-12a6-44f8-9702-06de13def790.mov

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2406 **Author:** [@pavelzw](https://github.com/pavelzw) **Created:** 3/7/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `autofill-refresh` --- ### 📝 Commits (10+) - [`e51233b`](https://github.com/bitwarden/android/commit/e51233bf9b4bfccf0f9469126a230df62c1db27d) Update README and CONTRIBUTING to use contributing.bitwarden.com (#1932) - [`448758a`](https://github.com/bitwarden/android/commit/448758a697b3287bef3a84cdde14d4f934ded250) Additional logic around filter display (#1951) - [`c53a85c`](https://github.com/bitwarden/android/commit/c53a85cd505465b72e92bbe6a19eed465daccf2f) [SG-390] Fix for missing org items with single org & personal ownership enabled (#1953) - [`3aef86b`](https://github.com/bitwarden/android/commit/3aef86bd3402f21d2f14249dfa04f5f5e3a8e04a) [SG-386] iOS Update user state when coming from background (#1952) - [`f24388c`](https://github.com/bitwarden/android/commit/f24388c1b5f81cb85193aec1450934028a6d7203) separate init and showVaultFilter property set (#1954) - [`7c311fb`](https://github.com/bitwarden/android/commit/7c311fbb5511b0a02e61b30978f5e4f67068b98e) fix for missing personal items added prior to joining org with personal ownership policy (#1955) - [`b250055`](https://github.com/bitwarden/android/commit/b2500557e79931ad6e957fd45b0501dfd3dc8153) SG-396 Fix tappable area after hiding account switching (#1956) - [`c892e9f`](https://github.com/bitwarden/android/commit/c892e9fa576c83b45967fc86bee47ccf2468fd70) Pin NuGet version (#1957) - [`109aeb4`](https://github.com/bitwarden/android/commit/109aeb49e4d380ce029a33b36ebd51c97ceb6764) [BEEEP] [PS-940] Support for dark theme selection while using Default (System) theme (#1959) - [`6e2e613`](https://github.com/bitwarden/android/commit/6e2e613fee87346e2f89cd3f626289767b3f7643) Add ssoToken to limit lifetime of SSO redirect (#1965) ### 📊 Changes **1 file changed** (+19 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AutofillCiphersPage.xaml` (+19 -12) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Closes #1710 This PR introduces the ability to pull to refresh in the autofill window like in the default app. ~~Since I am not able to run it in iOS, I didn't try it there... We probably still need to do some iOS specific stuff here... Any help is appreciated to try test it out there. I tried out #1939 but unfortunately don't have an Apple Developer account.~~ Works on iOS too. cc @danstooamerican ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AutofillCiphersPageViewModel.cs:** Add `RefreshAsync()` * **AutofillCiphersPage.xaml** Add `RefreshView` * **LoginListViewController.cs** Add `RefreshControl_ActivatedAsync()` * **LoginListViewController.designer.cs** Add `RefreshControl_ActivatedAsync` * **iOS.Autofill/MainInterface.storyboard** Add `refreshControl` * **iOS.Core/Views** Add `RefreshAsync()` ## Screenshots ### iOS https://user-images.githubusercontent.com/29506042/224867225-fa3adfc1-3f42-4085-a30d-f90e3d98fd59.mov ### Android https://user-images.githubusercontent.com/29506042/224867273-dd5dd4cc-12a6-44f8-9702-06de13def790.mov ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3546
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?