github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2370] [MERGED] [EC-980] Added iOS otpauth handler #3525

New Issue
Closed
opened 2025-11-26 23:33:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2370
Author: @fedemkr
Created: 2/14/2023
Status: ✅ Merged
Merged: 2/14/2023
Merged by: @fedemkr

Base: feature/EC-979-iOS-third-party-2fa ← Head: feature/ios-third-party-2fa/EC-980-ios-otpauth-handler

📝 Commits (3)

  • bbe00a2 EC-980 added Bitwarden as otpauth scheme handler
  • b101ec6 Merge branch 'master' into feature/ios-third-party-2fa/EC-980-ios-otpauth-handler
  • 2b6a61c EC-980 Fix format

📊 Changes

7 files changed (+59 additions, -4 deletions)

View changed files

📝 src/Android/Properties/AndroidManifest.xml (+2 -2)
➕ src/App/Abstractions/IDeepLinkContext.cs (+12 -0)
➕ src/App/Services/DeepLinkContext.cs (+29 -0)
📝 src/App/Utilities/AppSetup.cs (+4 -1)
📝 src/Core/Constants.cs (+1 -0)
📝 src/iOS/AppDelegate.cs (+3 -1)
📝 src/iOS/Info.plist (+8 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add otpauth scheme handling on iOS so that the app can handle TOTPs uris and can be selected in "Password options" -> "Set up verification codes using".

Code changes

  • Info.plist: Added otpauth scheme to be handled
  • AppDelegate: Added handling of Uris on OpenUrl
  • IDeepLinkContext, DeepLinkContext: Added this class to handle deep links, more logic here in the upcoming PRs for the feature
  • AppSetup: Registered IDeepLinkContext

Screenshots

Set up verification codes using Bitwarden

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2370 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/14/2023 **Status:** ✅ Merged **Merged:** 2/14/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/EC-979-iOS-third-party-2fa` ← **Head:** `feature/ios-third-party-2fa/EC-980-ios-otpauth-handler` --- ### 📝 Commits (3) - [`bbe00a2`](https://github.com/bitwarden/android/commit/bbe00a2305202b3c29b3bfe2665d1180f6d46186) EC-980 added Bitwarden as otpauth scheme handler - [`b101ec6`](https://github.com/bitwarden/android/commit/b101ec6f3de0eefe6a38a26de4e39d80a778aa46) Merge branch 'master' into feature/ios-third-party-2fa/EC-980-ios-otpauth-handler - [`2b6a61c`](https://github.com/bitwarden/android/commit/2b6a61c6df387c9f1a0b5a64768336d2847c0183) EC-980 Fix format ### 📊 Changes **7 files changed** (+59 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Properties/AndroidManifest.xml` (+2 -2) ➕ `src/App/Abstractions/IDeepLinkContext.cs` (+12 -0) ➕ `src/App/Services/DeepLinkContext.cs` (+29 -0) 📝 `src/App/Utilities/AppSetup.cs` (+4 -1) 📝 `src/Core/Constants.cs` (+1 -0) 📝 `src/iOS/AppDelegate.cs` (+3 -1) 📝 `src/iOS/Info.plist` (+8 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add otpauth scheme handling on iOS so that the app can handle TOTPs uris and can be selected in "Password options" -> "Set up verification codes using". ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Info.plist:** Added otpauth scheme to be handled * **AppDelegate:** Added handling of Uris on `OpenUrl` * **IDeepLinkContext, DeepLinkContext:** Added this class to handle deep links, more logic here in the upcoming PRs for the feature * **AppSetup:** Registered `IDeepLinkContext` ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="314" alt="Set up verification codes using Bitwarden" src="https://user-images.githubusercontent.com/15682323/218869131-10e4d507-a3c3-47cb-8a7d-7546d283c794.jpeg"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3525
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?