github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-24 23:32:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2357] [MERGED] [SG-1056] Fix login prompt loop for added accounts #3521

New Issue
Closed
opened 2025-11-26 23:33:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2357
Author: @LRNcardozoWDF
Created: 2/10/2023
Status: ✅ Merged
Merged: 2/10/2023
Merged by: @LRNcardozoWDF

Base: master ← Head: bug/SG-1056-Fix-prompt-account-already-added-loop

📝 Commits (2)

  • 1e6f2fe SG-1056 Fix login prompt loop for added accounts
  • c26c536 SG-1056 Fix PR comment

📊 Changes

1 file changed (+7 additions, -7 deletions)

View changed files

📝 src/App/Pages/Accounts/HomePageViewModel.cs (+7 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix ‘Account already added Would you like to switch to it now?’ prompt loop when performing login with an account already added.

Code changes

  • src/App/Pages/Accounts/HomePageViewModel.cs: Added new condition to only prompt the user if the chosen account is authenticated.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2357 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 2/10/2023 **Status:** ✅ Merged **Merged:** 2/10/2023 **Merged by:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Base:** `master` ← **Head:** `bug/SG-1056-Fix-prompt-account-already-added-loop` --- ### 📝 Commits (2) - [`1e6f2fe`](https://github.com/bitwarden/android/commit/1e6f2fe39c35daed0b34c4960261371e8839ea76) SG-1056 Fix login prompt loop for added accounts - [`c26c536`](https://github.com/bitwarden/android/commit/c26c536cb39a1b30291d40ddf2ec3d49816ea7f2) SG-1056 Fix PR comment ### 📊 Changes **1 file changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/HomePageViewModel.cs` (+7 -7) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix ‘Account already added Would you like to switch to it now?’ prompt loop when performing login with an account already added. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/App/Pages/Accounts/HomePageViewModel.cs:** Added new condition to only prompt the user if the chosen account is authenticated. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3521
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?