github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2331] [MERGED] [PS-2330][PS-2329][PS-2332][PS-2333] Checking for username terms on Android Autofill #3505

New Issue
Closed
opened 2025-11-26 23:33:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2331
Author: @aj-rosado
Created: 1/27/2023
Status: ✅ Merged
Merged: 2/1/2023
Merged by: @aj-rosado

Base: master ← Head: bug/PS-2330-2329-2332-2333-autofill

📝 Commits (1)

  • 579dead [PS-2330][PS-2339][PS-2332][PS-2333] Checking for username terms when adding a password, if they exist don't add. Adding fields that contain username terms to the usernamefields collection

📊 Changes

1 file changed (+12 additions, -1 deletions)

View changed files

📝 src/Android/Autofill/FieldCollection.cs (+12 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Improving the way we recognize fields as Username and Password at the login autofill to avoid filling username fields with passwords or not detecting username fields as valid username fields

Code changes

  • FieldCollection.cs: Added common username terms
    On fields that identify as password we check if they don't have "Username terms" on hints to avoid filling passwords on usernames.
    In cases we haven't found any Username Field, we will check if there is any Field with any hint or IdEntry that matches our "Username Terms"

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2331 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 1/27/2023 **Status:** ✅ Merged **Merged:** 2/1/2023 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `bug/PS-2330-2329-2332-2333-autofill` --- ### 📝 Commits (1) - [`579dead`](https://github.com/bitwarden/android/commit/579dead46f29965bad5ee293e032c0e40d9b5108) [PS-2330][PS-2339][PS-2332][PS-2333] Checking for username terms when adding a password, if they exist don't add. Adding fields that contain username terms to the usernamefields collection ### 📊 Changes **1 file changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/FieldCollection.cs` (+12 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Improving the way we recognize fields as Username and Password at the login autofill to avoid filling username fields with passwords or not detecting username fields as valid username fields ## Code changes * **FieldCollection.cs:** Added common username terms On fields that identify as password we check if they don't have "Username terms" on hints to avoid filling passwords on usernames. In cases we haven't found any Username Field, we will check if there is any Field with any hint or IdEntry that matches our "Username Terms" ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?