github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2284] [MERGED] [SG-912] Modify the mobile app to retrieve the user's avatar color #3482

New Issue
Closed
opened 2025-11-26 23:33:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2284
Author: @BrandonM-Bitwarden
Created: 1/9/2023
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @BrandonM-Bitwarden

Base: master ← Head: changes/SG-912-signed

📝 Commits (2)

  • 75d54e6 [SG-912] Modify the mobile app to retrieve the user's avatar color (#2277)
  • b7466cd fix: single state grab is cool

📊 Changes

11 files changed (+43 additions, -10 deletions)

View changed files

📝 src/App/Controls/AccountViewCell/AccountViewCellViewModel.cs (+1 -1)
📝 src/App/Controls/AvatarImageSource.cs (+5 -3)
📝 src/App/Controls/AvatarImageSourcePool.cs (+4 -4)
📝 src/App/Pages/BaseContentPage.cs (+2 -2)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+4 -0)
📝 src/Core/Abstractions/IStateService.cs (+4 -0)
📝 src/Core/Models/Domain/Account.cs (+2 -0)
📝 src/Core/Models/Response/ProfileResponse.cs (+1 -0)
📝 src/Core/Models/View/AccountView.cs (+2 -0)
📝 src/Core/Services/StateService.cs (+17 -0)
📝 src/Core/Services/SyncService.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Signed branch of https://github.com/bitwarden/mobile/pull/2277/files

Code changes

~src/App/Controls/AccountViewCell/AccountViewCellViewModel.cs: Added new field to avatar builder
~src/App/Controls/AvatarImageSource.cs: Added new field
~src/App/Controls/AvatarImageSourcePool.cs: Added new cache key value
~src/App/Pages/BaseContentPage.cs: adjusted state getter to pull once and for avatar
~src/App/Pages/BaseContentPage.cs: added refresh for avatar
~src/Core/Abstractions/IStateService.cs: Added new methods
~src/Core/Models/Domain/Account.cs: Added new field
~src/Core/Models/Response/ProfileResponse.cs: Added new field
~src/Core/Models/View/AccountView.cs: Added new field
~src/Core/Services/StateService.cs: Addded getters from profile
~src/Core/Services/SyncService.cs: added save for profile on sync

Screenshots

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2284 **Author:** [@BrandonM-Bitwarden](https://github.com/BrandonM-Bitwarden) **Created:** 1/9/2023 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@BrandonM-Bitwarden](https://github.com/BrandonM-Bitwarden) **Base:** `master` ← **Head:** `changes/SG-912-signed` --- ### 📝 Commits (2) - [`75d54e6`](https://github.com/bitwarden/android/commit/75d54e6ee778c1475c451982fb2059901862f3cb) [SG-912] Modify the mobile app to retrieve the user's avatar color (#2277) - [`b7466cd`](https://github.com/bitwarden/android/commit/b7466cdf03b3ea8f20040ae0b35b6f44bdd7537c) fix: single state grab is cool ### 📊 Changes **11 files changed** (+43 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/AccountViewCell/AccountViewCellViewModel.cs` (+1 -1) 📝 `src/App/Controls/AvatarImageSource.cs` (+5 -3) 📝 `src/App/Controls/AvatarImageSourcePool.cs` (+4 -4) 📝 `src/App/Pages/BaseContentPage.cs` (+2 -2) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+4 -0) 📝 `src/Core/Abstractions/IStateService.cs` (+4 -0) 📝 `src/Core/Models/Domain/Account.cs` (+2 -0) 📝 `src/Core/Models/Response/ProfileResponse.cs` (+1 -0) 📝 `src/Core/Models/View/AccountView.cs` (+2 -0) 📝 `src/Core/Services/StateService.cs` (+17 -0) 📝 `src/Core/Services/SyncService.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Signed branch of https://github.com/bitwarden/mobile/pull/2277/files <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes ~src/App/Controls/AccountViewCell/AccountViewCellViewModel.cs: Added new field to avatar builder ~src/App/Controls/AvatarImageSource.cs: Added new field ~src/App/Controls/AvatarImageSourcePool.cs: Added new cache key value ~src/App/Pages/BaseContentPage.cs: adjusted state getter to pull once and for avatar ~src/App/Pages/BaseContentPage.cs: added refresh for avatar ~src/Core/Abstractions/IStateService.cs: Added new methods ~src/Core/Models/Domain/Account.cs: Added new field ~src/Core/Models/Response/ProfileResponse.cs: Added new field ~src/Core/Models/View/AccountView.cs: Added new field ~src/Core/Services/StateService.cs: Addded getters from profile ~src/Core/Services/SyncService.cs: added save for profile on sync ## Screenshots ![image](https://user-images.githubusercontent.com/107377945/211387275-6604d007-0fbd-4d81-a808-827ed3b8075c.png) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3482
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?