github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3613] [MERGED] PM-9937 an existing email should be able to add account from a different hosted instance. #34783

New Issue
Closed
opened 2026-04-21 02:16:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:16:41 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3613
Author: @dseverns-livefront
Created: 7/23/2024
Status: ✅ Merged
Merged: 7/23/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-9937/same-email-different-host

📝 Commits (1)

  • 4c98ba6 PM-9937 check environment host label to see if the account is the same when adding new one

📊 Changes

3 files changed (+74 additions, -5 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt (+10 -3)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreenTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt (+63 -2)

📄 Description

🎟️ Tracking

PM-9937

📔 Objective

If a user is trying to use the same email to sign in or create account using an existing email tied to another account but on a different host instance they should be able to.

📸 Screenshots

https://github.com/user-attachments/assets/10132144-319a-4897-8080-b3c387e0e30d

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3613 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 7/23/2024 **Status:** ✅ Merged **Merged:** 7/23/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-9937/same-email-different-host` --- ### 📝 Commits (1) - [`4c98ba6`](https://github.com/bitwarden/android/commit/4c98ba627e51228cd0febc175e586207b47b1662) PM-9937 check environment host label to see if the account is the same when adding new one ### 📊 Changes **3 files changed** (+74 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt` (+10 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreenTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt` (+63 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-9937](https://bitwarden.atlassian.net/browse/PM-9937) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective If a user is trying to use the same email to sign in or create account using an existing email tied to another account but on a different host instance they should be able to. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/10132144-319a-4897-8080-b3c387e0e30d <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-9937]: https://bitwarden.atlassian.net/browse/PM-9937?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:16:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34783