github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 06:11:38 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2277] [MERGED] [SG-912] Modify the mobile app to retrieve the user's avatar color #3477

New Issue
Closed
opened 2025-11-26 23:33:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2277
Author: @BrandonM-Bitwarden
Created: 1/5/2023
Status: ✅ Merged
Merged: 1/9/2023
Merged by: @BrandonM-Bitwarden

Base: changes/SG-912-signed ← Head: changes/SG-912

📝 Commits (10+)

📊 Changes

11 files changed (+42 additions, -9 deletions)

View changed files

📝 src/App/Controls/AccountViewCell/AccountViewCellViewModel.cs (+1 -1)
📝 src/App/Controls/AvatarImageSource.cs (+5 -3)
📝 src/App/Controls/AvatarImageSourcePool.cs (+4 -4)
📝 src/App/Pages/BaseContentPage.cs (+1 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+4 -0)
📝 src/Core/Abstractions/IStateService.cs (+4 -0)
📝 src/Core/Models/Domain/Account.cs (+2 -0)
📝 src/Core/Models/Response/ProfileResponse.cs (+1 -0)
📝 src/Core/Models/View/AccountView.cs (+2 -0)
📝 src/Core/Services/StateService.cs (+17 -0)
📝 src/Core/Services/SyncService.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With the introduction of custom Avatar Colors, the correct custom color must be shown.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2277 **Author:** [@BrandonM-Bitwarden](https://github.com/BrandonM-Bitwarden) **Created:** 1/5/2023 **Status:** ✅ Merged **Merged:** 1/9/2023 **Merged by:** [@BrandonM-Bitwarden](https://github.com/BrandonM-Bitwarden) **Base:** `changes/SG-912-signed` ← **Head:** `changes/SG-912` --- ### 📝 Commits (10+) - [`6308990`](https://github.com/bitwarden/android/commit/63089909cd493d185dbdc5db280c8072c6e3838d) work: baseline - [`32514a8`](https://github.com/bitwarden/android/commit/32514a80efd7f87e0e6642d819038e81a790287e) fix: dont use profile for store - [`89c230b`](https://github.com/bitwarden/android/commit/89c230ba5237d49b8fda8e0a47e6aa70a6dbc27f) fiix: use userid in key - [`b68cb5f`](https://github.com/bitwarden/android/commit/b68cb5f94107fbb7998b0794bcd45dc28ceecbaa) Merge branch 'master' into changes/SG-912 - [`dc9e015`](https://github.com/bitwarden/android/commit/dc9e01506e6b408bd3f4445f9e3f1e1d4298187e) fix: lookup on AccountView list create - [`c6c0bdf`](https://github.com/bitwarden/android/commit/c6c0bdf6dbbd53228970c3714c55ffd1b0901847) Merge branch 'master' into changes/SG-912 - [`ffc899b`](https://github.com/bitwarden/android/commit/ffc899bc54fef0687f43d82ae19bd5cf953fc4f3) fix my own bad advice + tweaks - [`27a70bf`](https://github.com/bitwarden/android/commit/27a70bf761896c8ecddc5b11bc83e4440a1c4a23) Autosync the updated translations (#2279) - [`246a1cc`](https://github.com/bitwarden/android/commit/246a1ccba5b5e443be121704198cfb2a74620315) fix my own bad advice + tweaks - [`1706878`](https://github.com/bitwarden/android/commit/1706878fa8854b9c22e9bcbcd48a32dea147afc9) Merge branch 'changes/SG-912' of https://github.com/bitwarden/mobile into changes/SG-912 ### 📊 Changes **11 files changed** (+42 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/AccountViewCell/AccountViewCellViewModel.cs` (+1 -1) 📝 `src/App/Controls/AvatarImageSource.cs` (+5 -3) 📝 `src/App/Controls/AvatarImageSourcePool.cs` (+4 -4) 📝 `src/App/Pages/BaseContentPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+4 -0) 📝 `src/Core/Abstractions/IStateService.cs` (+4 -0) 📝 `src/Core/Models/Domain/Account.cs` (+2 -0) 📝 `src/Core/Models/Response/ProfileResponse.cs` (+1 -0) 📝 `src/Core/Models/View/AccountView.cs` (+2 -0) 📝 `src/Core/Services/StateService.cs` (+17 -0) 📝 `src/Core/Services/SyncService.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> With the introduction of custom Avatar Colors, the correct custom color must be shown. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?