github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 06:11:38 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2274] [MERGED] [PS-2162] Add needs-qa label to enforce-labels workflow #3475

New Issue
Closed
opened 2025-11-26 23:33:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2274
Author: @djsmith85
Created: 1/3/2023
Status: ✅ Merged
Merged: 1/3/2023
Merged by: @djsmith85

Base: master ← Head: update-enforce-labels-workflow

📝 Commits (1)

  • 223ac09 Add needs-qa label to BANNED_LABELS

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 .github/workflows/enforce-labels.yml (+2 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

I realized via https://github.com/bitwarden/mobile/pull/2044 that we do not block merging when the needs-qa-label was added.

The enforcement on the needs-qa label was added with https://github.com/bitwarden/clients/pull/3450 for the clients and with https://github.com/bitwarden/server/pull/2248 for the server, but we must have missed the mobile repo.

Code changes

  • .github/workflows/enforce-labels.yml: Add needs-qa to the BANNED_LABELS and mentioned it in the description.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2274 **Author:** [@djsmith85](https://github.com/djsmith85) **Created:** 1/3/2023 **Status:** ✅ Merged **Merged:** 1/3/2023 **Merged by:** [@djsmith85](https://github.com/djsmith85) **Base:** `master` ← **Head:** `update-enforce-labels-workflow` --- ### 📝 Commits (1) - [`223ac09`](https://github.com/bitwarden/android/commit/223ac09fe45fb8808b92723670e85c881511ae5d) Add `needs-qa` label to BANNED_LABELS ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/enforce-labels.yml` (+2 -2) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ## Objective I realized via https://github.com/bitwarden/mobile/pull/2044 that we do not block merging when the `needs-qa`-label was added. The enforcement on the `needs-qa` label was added with https://github.com/bitwarden/clients/pull/3450 for the clients and with https://github.com/bitwarden/server/pull/2248 for the server, but we must have missed the mobile repo. ## Code changes * **.github/workflows/enforce-labels.yml:** Add `needs-qa` to the BANNED_LABELS and mentioned it in the description. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3475
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?