github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-11 04:04:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3448] [MERGED] [PM-8137] Respond to SDK user verification callbacks implicitly #34730

New Issue
Closed
opened 2026-04-21 02:14:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:14:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3448
Author: @SaintPatrck
Created: 7/11/2024
Status: ✅ Merged
Merged: 7/12/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-8137/update-vault-sdk-source

📝 Commits (9)

  • 4618196 Refactor PublicKeyCredentialCreationOptions to match WebAuthn spec
  • 6cb5b3e Rename Fido2 credential registration result object
  • 55e7d2d Merge branch 'main' into PM-8137/refactor-passkey-create-result
  • fc97edd Improve test coverage
  • 329516e Introduce user verification prompt
  • 1ea44f6 Respond to SDK user verification callbacks implicitly
  • ed2bde0 Remove fido2 interface implementation lambda args
  • e7aa3b1 Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/update-vault-sdk-source
  • c579b34 Reduce code duplication in tests

📊 Changes

10 files changed (+186 additions, -256 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt (+15 -19)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt (+2 -37)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+13 -34)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/AuthenticateFido2CredentialRequest.kt (+26 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialAuthenticationUserInterfaceImpl.kt (+3 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialRegistrationUserInterfaceImpl.kt (+6 -7)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/util/PublicKeyCredentialAuthenticatorAttestationResponseExtensions.kt (+2 -5)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt (+0 -10)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt (+90 -114)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/PublicKeyCredentialCreationOptionsTestHelpers.kt (+29 -26)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8137

📔 Objective

Remove passkey registration and authentication lambda arguments that were responsible for triggering user verification within the client application.

The callback flow required by BitwardenSDK does not play well with the async/reactive architecture of the application. To circumvent the incompatibility we are temporarily evaluating passkey operation request options to determine if user verfification is required prior to engaging the SDK. This approach allows us to implicitly respond to SDK requests for user checking and credential selection.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3448 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/11/2024 **Status:** ✅ Merged **Merged:** 7/12/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-8137/update-vault-sdk-source` --- ### 📝 Commits (9) - [`4618196`](https://github.com/bitwarden/android/commit/46181968e69233806bc3a1111ce00040adcd8737) Refactor PublicKeyCredentialCreationOptions to match WebAuthn spec - [`6cb5b3e`](https://github.com/bitwarden/android/commit/6cb5b3e603f9eaca3ee62876f96e28f4f47403a5) Rename Fido2 credential registration result object - [`55e7d2d`](https://github.com/bitwarden/android/commit/55e7d2d7ae2ece18f4f15e0393b1886c229d973a) Merge branch 'main' into PM-8137/refactor-passkey-create-result - [`fc97edd`](https://github.com/bitwarden/android/commit/fc97edd7759bd0cc5635126ba993670833c75e74) Improve test coverage - [`329516e`](https://github.com/bitwarden/android/commit/329516e13535f5494f4cf739a947f805e01143a8) Introduce user verification prompt - [`1ea44f6`](https://github.com/bitwarden/android/commit/1ea44f664fb178e8045bf41d9255059b141e86bb) Respond to SDK user verification callbacks implicitly - [`ed2bde0`](https://github.com/bitwarden/android/commit/ed2bde05bb42e64961ff3ef65c1ea66ea5e935f6) Remove fido2 interface implementation lambda args - [`e7aa3b1`](https://github.com/bitwarden/android/commit/e7aa3b19d283b760e2a653c6efc03c3056f53445) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/update-vault-sdk-source - [`c579b34`](https://github.com/bitwarden/android/commit/c579b34e20542ff02da5c24f24b0259b60c6bb56) Reduce code duplication in tests ### 📊 Changes **10 files changed** (+186 additions, -256 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt` (+15 -19) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt` (+2 -37) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+13 -34) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/AuthenticateFido2CredentialRequest.kt` (+26 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialAuthenticationUserInterfaceImpl.kt` (+3 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialRegistrationUserInterfaceImpl.kt` (+6 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/util/PublicKeyCredentialAuthenticatorAttestationResponseExtensions.kt` (+2 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt` (+0 -10) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt` (+90 -114) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/PublicKeyCredentialCreationOptionsTestHelpers.kt` (+29 -26) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-8137 ## 📔 Objective Remove passkey registration and authentication lambda arguments that were responsible for triggering user verification within the client application. The callback flow required by BitwardenSDK does not play well with the async/reactive architecture of the application. To circumvent the incompatibility we are temporarily evaluating passkey operation request options to determine if user verfification is required prior to engaging the SDK. This approach allows us to implicitly respond to SDK requests for user checking and credential selection. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:14:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34730
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?