github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3371] [MERGED] [PM-8985] Fetch all tags when checking out repo for build job #34678

New Issue
Closed
opened 2026-04-21 02:12:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:12:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3371
Author: @SaintPatrck
Created: 6/27/2024
Status: ✅ Merged
Merged: 6/27/2024
Merged by: @SaintPatrck

Base: main ← Head: pm-8985/fetch-tags-during-checkout

📝 Commits (7)

  • 5411c15 [PM-8985] Fetch all tags when checking out repo for build job
  • 8472b55 Fetch a treeless clone
  • a1e5e6e Fetch tags before calculating next version name
  • d7771b1 Revert action options since they are not respected
  • 996c185 Sort by taggerdate
  • 8bf9446 Use describe to capture latest tag
  • 095a803 Uncomment saving version changes

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 fastlane/Fastfile (+4 -2)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8985

📔 Objective

Fetch all tags during build job checkout so that they are available to calculate the correct version name.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3371 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 6/27/2024 **Status:** ✅ Merged **Merged:** 6/27/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `pm-8985/fetch-tags-during-checkout` --- ### 📝 Commits (7) - [`5411c15`](https://github.com/bitwarden/android/commit/5411c1573de77c3a606d8864cba4814f5f0b3ba4) [PM-8985] Fetch all tags when checking out repo for build job - [`8472b55`](https://github.com/bitwarden/android/commit/8472b55c7bf300a2e9f593360181831a9915c6c8) Fetch a treeless clone - [`a1e5e6e`](https://github.com/bitwarden/android/commit/a1e5e6e9b0ff3a06a119d1dccb249671376df57e) Fetch tags before calculating next version name - [`d7771b1`](https://github.com/bitwarden/android/commit/d7771b1fb414787f760494d11429c64839133280) Revert action options since they are not respected - [`996c185`](https://github.com/bitwarden/android/commit/996c1853a61243eecc746a719567be1bd40b4e6f) Sort by taggerdate - [`8bf9446`](https://github.com/bitwarden/android/commit/8bf94463955df727b0eb2e5b46cfc5185e520a91) Use describe to capture latest tag - [`095a803`](https://github.com/bitwarden/android/commit/095a803dd95a8f0c7b42c3a9321061107d83b726) Uncomment saving version changes ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `fastlane/Fastfile` (+4 -2) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-8985 ## 📔 Objective Fetch all tags during build job checkout so that they are available to calculate the correct version name. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:12:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?