github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2258] [MERGED] [EC-820] Added icons for Apple Watch Complication and Watch app icons #3464

New Issue
Closed
opened 2025-11-26 23:33:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2258
Author: @fedemkr
Created: 12/23/2022
Status: ✅ Merged
Merged: 12/23/2022
Merged by: @vvolkgang

Base: master ← Head: bug/EC-820-fix-watch-complication-icons

📝 Commits (2)

  • 7c70cf6 EC-820 Added icons for Watch Complication and updated the Watch app icons
  • 3b62b1c Merge branch 'master' into bug/EC-820-fix-watch-complication-icons

📊 Changes

55 files changed (+31 additions, -16 deletions)

View changed files

➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/100.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/102.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/172.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/196.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/216.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/234.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/48.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/55.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/66.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/88.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/92.png (+0 -0)
📝 src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Contents.json (+17 -15)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Icon-1024.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Icon-59.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Icon-80.png (+0 -0)
➖ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Icon-87.png (+0 -0)
➕ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Watch234ShortLook.png (+0 -0)
➕ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Watch258ShortLook.png (+0 -0)
➕ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Watch38MM42MMHomeScreen.png (+0 -0)
➕ src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Watch38MMShortLook.png (+0 -0)

...and 35 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix Apple Watch Complication icon and update the Watch app ones without gradient.

Code changes

  • ...: Added/Updated icons

Screenshots

New base icon:
new icon

Watch App icon:
Watch App new icon

On the complication it's being shown with the old one, maybe I had something cached that didn't cleaned properly, we'll see how it's shown on testing, but at least now it shows an icon.
Complication

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2258 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 12/23/2022 **Status:** ✅ Merged **Merged:** 12/23/2022 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `master` ← **Head:** `bug/EC-820-fix-watch-complication-icons` --- ### 📝 Commits (2) - [`7c70cf6`](https://github.com/bitwarden/android/commit/7c70cf6997b7e1435fd8a69f8d192277cd5c734d) EC-820 Added icons for Watch Complication and updated the Watch app icons - [`3b62b1c`](https://github.com/bitwarden/android/commit/3b62b1cf413e2469e1ed4e2be1ea9b208a68c4f9) Merge branch 'master' into bug/EC-820-fix-watch-complication-icons ### 📊 Changes **55 files changed** (+31 additions, -16 deletions) <details> <summary>View changed files</summary> ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/100.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/102.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/172.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/196.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/216.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/234.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/48.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/55.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/66.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/88.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/92.png` (+0 -0) 📝 `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Contents.json` (+17 -15) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Icon-1024.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Icon-59.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Icon-80.png` (+0 -0) ➖ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Icon-87.png` (+0 -0) ➕ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Watch234ShortLook.png` (+0 -0) ➕ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Watch258ShortLook.png` (+0 -0) ➕ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Watch38MM42MMHomeScreen.png` (+0 -0) ➕ `src/watchOS/bitwarden/bitwarden WatchKit App/Assets.xcassets/AppIcon.appiconset/Watch38MMShortLook.png` (+0 -0) _...and 35 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix Apple Watch Complication icon and update the Watch app ones without gradient. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **...:** Added/Updated icons ## Screenshots <!--Required for any UI changes. Delete if not applicable--> New base icon: ![new icon](https://user-images.githubusercontent.com/15682323/209332629-81a9fd09-d174-496d-9ccf-f06f40f275f5.png) Watch App icon: ![Watch App new icon](https://user-images.githubusercontent.com/15682323/209333104-420901e4-e2ad-4507-af33-6e16af1331db.PNG) On the complication it's being shown with the old one, maybe I had something cached that didn't cleaned properly, we'll see how it's shown on testing, but at least now it shows an icon. ![Complication](https://user-images.githubusercontent.com/15682323/209332792-fe39748f-345e-4b37-ad14-3757628bcd2a.PNG) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3464
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?