github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2256] [MERGED] [EC-847] Improve Watch list UI performance #3462

New Issue
Closed
opened 2025-11-26 23:33:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2256
Author: @fedemkr
Created: 12/21/2022
Status: ✅ Merged
Merged: 12/22/2022
Merged by: @vvolkgang

Base: master ← Head: EC-847-improve-watch-list-performance

📝 Commits (1)

  • 18ee734 EC-847 improved watch list ui performance by removing the animations on the search box and going back to the simple List instead of the TrackableWithHeaderListView

📊 Changes

1 file changed (+24 additions, -36 deletions)

View changed files

📝 src/watchOS/bitwarden/bitwarden WatchKit Extension/Views/CipherListView.swift (+24 -36)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Improve the Apple Watch cipher list performance where the scrolling was not smooth.

Code changes

  • CipherListView: Removed animations of the Search box and also moved back to the simple List instead of the TrackableWithHeaderListView

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2256 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 12/21/2022 **Status:** ✅ Merged **Merged:** 12/22/2022 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `master` ← **Head:** `EC-847-improve-watch-list-performance` --- ### 📝 Commits (1) - [`18ee734`](https://github.com/bitwarden/android/commit/18ee734d35641b42d4ad31f163d9aaeeb75505f9) EC-847 improved watch list ui performance by removing the animations on the search box and going back to the simple List instead of the TrackableWithHeaderListView ### 📊 Changes **1 file changed** (+24 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/watchOS/bitwarden/bitwarden WatchKit Extension/Views/CipherListView.swift` (+24 -36) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Improve the Apple Watch cipher list performance where the scrolling was not smooth. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherListView:** Removed animations of the Search box and also moved back to the simple `List` instead of the `TrackableWithHeaderListView` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3462
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?