github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 12:36:15 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3190] [MERGED] [PM-7658] Implement Fido2 privileged apps verification #34581

New Issue
Closed
opened 2026-04-21 02:07:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:07:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3190
Author: @fedemkr
Created: 4/24/2024
Status: ✅ Merged
Merged: 4/25/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: mobiletf/pm-7658/verify-priviliged-apps

📝 Commits (3)

  • aaa45b1 PM-7553 Fix native apps passkeys autofill and creation
  • 24ed46b PM-7658 Implemented Fido2 priviliged apps verification
  • b80c856 Merge branch 'feature/maui-migration-passkeys' into mobiletf/pm-7658/verify-priviliged-apps

📊 Changes

4 files changed (+543 additions, -5 deletions)

View changed files

📝 src/App/App.csproj (+5 -0)
📝 src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+55 -2)
📝 src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs (+2 -3)
➕ src/App/Resources/Raw/fido2_priviliged_allow_list.json (+481 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implement Fido2 privileged apps verification on Android

Note: Wait for #3188 to be merged in order to merge this one.

Code changes

  • fido2_priviliged_allow_list.json: Json file with all the allowed privileged apps to be used in the Fido2 flows.
  • CredentialHelpers: Added helper methods to load the aforementioned file and do the verifications getting the proper origin at the end.
  • Others: Implemented the verifications for the calling app and to get the origin correctly

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3190 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/24/2024 **Status:** ✅ Merged **Merged:** 4/25/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `mobiletf/pm-7658/verify-priviliged-apps` --- ### 📝 Commits (3) - [`aaa45b1`](https://github.com/bitwarden/android/commit/aaa45b18a4551d8092019a03fe3b3d26af35538d) PM-7553 Fix native apps passkeys autofill and creation - [`24ed46b`](https://github.com/bitwarden/android/commit/24ed46b530174c3f8363e50b5d8a9f04d3134433) PM-7658 Implemented Fido2 priviliged apps verification - [`b80c856`](https://github.com/bitwarden/android/commit/b80c8569c02bb6e46254115dea2b574e8997ec54) Merge branch 'feature/maui-migration-passkeys' into mobiletf/pm-7658/verify-priviliged-apps ### 📊 Changes **4 files changed** (+543 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+5 -0) 📝 `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+55 -2) 📝 `src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs` (+2 -3) ➕ `src/App/Resources/Raw/fido2_priviliged_allow_list.json` (+481 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implement Fido2 privileged apps verification on Android Note: Wait for #3188 to be merged in order to merge this one. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **fido2_priviliged_allow_list.json:** Json file with all the allowed privileged apps to be used in the Fido2 flows. * **CredentialHelpers:** Added helper methods to load the aforementioned file and do the verifications getting the proper origin at the end. * **Others:** Implemented the verifications for the calling app and to get the origin correctly ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:07:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?