github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-10 22:33:31 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2239] [MERGED] [SG-564][SG-565] Check Exposed Password #3450

New Issue
Closed
opened 2025-11-26 23:32:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:32:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2239
Author: @andrebispo5
Created: 12/14/2022
Status: ✅ Merged
Merged: 1/4/2023
Merged by: @andrebispo5

Base: feature/mp-security-checks ← Head: feature/SG-564-mp-exposed

📝 Commits (10+)

  • e764c45 [SG-886] Add password strength indicator control
  • b05d470 [SG-570] Add weak password dialog check
  • 9593afe code format
  • b940107 [SG-886] rename enum password strength
  • 1bd054b [SG-564] [SG-565] Add check for exposed password and show dialog
  • 3803f58 code format
  • 994fce6 Merge branch 'feature/mp-security-checks' into feature/SG-886-mp-strength
  • 4f365d4 [SG-886] Change control scale
  • 24bdb46 [SG-886] Move calculate user inputs to IPasswordGenerationService, refactor.
  • 925f778 [SG-886] Move formatted string to xaml. Move minimum chars to constant

📊 Changes

5 files changed (+127 additions, -7 deletions)

View changed files

📝 src/App/Pages/Accounts/RegisterPage.xaml (+11 -0)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+50 -7)
📝 src/App/Pages/BaseViewModel.cs (+6 -0)
📝 src/App/Resources/AppResources.Designer.cs (+45 -0)
📝 src/App/Resources/AppResources.resx (+15 -0)

📄 Description

DEPENDS ON: https://github.com/bitwarden/mobile/pull/2238

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

During registration give the user the possibility to perform a password check before creating an account.

Code changes

The registration page now has a new toggle to perform an expose password check.
There are also 3 different dialog scenarios:

  1. Weak Password
  2. Exposed Password
  3. Weak and Exposed Password

Screenshots

https://user-images.githubusercontent.com/4648522/207650245-ad35d658-fdba-438f-9099-8328951c78fd.mov

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2239 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 12/14/2022 **Status:** ✅ Merged **Merged:** 1/4/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/mp-security-checks` ← **Head:** `feature/SG-564-mp-exposed` --- ### 📝 Commits (10+) - [`e764c45`](https://github.com/bitwarden/android/commit/e764c456468b388ef1e866cde7c652eeaa13aea9) [SG-886] Add password strength indicator control - [`b05d470`](https://github.com/bitwarden/android/commit/b05d470f5deb8588228e93d8d463c6d12fd2d780) [SG-570] Add weak password dialog check - [`9593afe`](https://github.com/bitwarden/android/commit/9593afebac1dba28a212b038bcf5fc97a7bc2546) code format - [`b940107`](https://github.com/bitwarden/android/commit/b9401075d07db24bf621a3a1bef830aca778bd5b) [SG-886] rename enum password strength - [`1bd054b`](https://github.com/bitwarden/android/commit/1bd054b2ccb494cc11ca7b22ef6eaac72d9ada5a) [SG-564] [SG-565] Add check for exposed password and show dialog - [`3803f58`](https://github.com/bitwarden/android/commit/3803f58eae744b46dbc1952ee8051f8d6285d6b6) code format - [`994fce6`](https://github.com/bitwarden/android/commit/994fce64e6e1f0d7b9308de70ffb68cfa37e8791) Merge branch 'feature/mp-security-checks' into feature/SG-886-mp-strength - [`4f365d4`](https://github.com/bitwarden/android/commit/4f365d4a8182c105bd85cbdd3552e271888cc7cb) [SG-886] Change control scale - [`24bdb46`](https://github.com/bitwarden/android/commit/24bdb4666fe4484cf2d13ede8298e5110be77c3c) [SG-886] Move calculate user inputs to IPasswordGenerationService, refactor. - [`925f778`](https://github.com/bitwarden/android/commit/925f778dd45be088e47b6010e3e1ad7a4b35a5d3) [SG-886] Move formatted string to xaml. Move minimum chars to constant ### 📊 Changes **5 files changed** (+127 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/RegisterPage.xaml` (+11 -0) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+50 -7) 📝 `src/App/Pages/BaseViewModel.cs` (+6 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+45 -0) 📝 `src/App/Resources/AppResources.resx` (+15 -0) </details> ### 📄 Description DEPENDS ON: https://github.com/bitwarden/mobile/pull/2238 ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> During registration give the user the possibility to perform a password check before creating an account. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> The registration page now has a new toggle to perform an expose password check. There are also 3 different dialog scenarios: 1. Weak Password 2. Exposed Password 3. Weak and Exposed Password ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://user-images.githubusercontent.com/4648522/207650245-ad35d658-fdba-438f-9099-8328951c78fd.mov ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:32:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3450
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?