github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3042] [MERGED] [PM-5916] Fix for incorrect fonts in fingerprint phrases #34484

New Issue
Closed
opened 2026-04-21 02:03:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:03:57 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3042
Author: @dinisvieira
Created: 2/28/2024
Status: ✅ Merged
Merged: 2/29/2024
Merged by: @dinisvieira

Base: main ← Head: feature/PM-5916-incorrect-font-in-fingerprint-phrases

📝 Commits (1)

  • 5cf2b07 PM-5916 Fix for incorrect fonts in fingerprint phrases

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 src/Core/Pages/Accounts/LoginPasswordlessPage.xaml (+1 -1)
📝 src/Core/Pages/Accounts/LoginPasswordlessRequestPage.xaml (+1 -1)
📝 src/Core/Pages/Settings/LoginPasswordlessRequestsListPage.xaml (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fingerprint phrases are being shown with the incorrect font

Code changes

The correct font is set for MonoLabel but apparently they are not set when using FormattedText.
Changing to Text instead fixes the issue. (FormattedText doesn't really seem to be needed in this scenario)
I applied this to other MonoLabel in the app that had the same issue.

  • LoginPasswordlessPage.xaml: Changed FormattedText to Text
  • LoginPasswordlessRequestPage.xaml: Changed FormattedText to Text
  • LoginPasswordlessRequestsListPage.xaml: Changed FormattedText to Text

Screenshots

Before After
Before After

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3042 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/28/2024 **Status:** ✅ Merged **Merged:** 2/29/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `feature/PM-5916-incorrect-font-in-fingerprint-phrases` --- ### 📝 Commits (1) - [`5cf2b07`](https://github.com/bitwarden/android/commit/5cf2b07744c11c928913c3adf9d03f765f0b5429) PM-5916 Fix for incorrect fonts in fingerprint phrases ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Accounts/LoginPasswordlessPage.xaml` (+1 -1) 📝 `src/Core/Pages/Accounts/LoginPasswordlessRequestPage.xaml` (+1 -1) 📝 `src/Core/Pages/Settings/LoginPasswordlessRequestsListPage.xaml` (+1 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fingerprint phrases are being shown with the incorrect font ## Code changes The correct font is set for MonoLabel but apparently they are not set when using FormattedText. Changing to Text instead fixes the issue. (FormattedText doesn't really seem to be needed in this scenario) I applied this to other MonoLabel in the app that had the same issue. * **LoginPasswordlessPage.xaml:** Changed `FormattedText` to `Text` * **LoginPasswordlessRequestPage.xaml:** Changed `FormattedText` to `Text` * **LoginPasswordlessRequestsListPage.xaml:** Changed `FormattedText` to `Text` ## Screenshots Before | After :-------------------------:|:-------------------------: ![Before](https://github.com/bitwarden/mobile/assets/2824952/f4530f16-cf8a-4bf2-807b-04a63290f035) | ![After](https://github.com/bitwarden/mobile/assets/2824952/8a1ca494-99e0-4b7f-b980-eb48acd76ec9) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:03:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34484