github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2703] [MERGED] [PM-3512] Settings Appearance #34253

New Issue
Closed
opened 2026-04-21 01:53:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:53:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2703
Author: @fedemkr
Created: 8/17/2023
Status: ✅ Merged
Merged: 8/18/2023
Merged by: @fedemkr

Base: vault/pm-2658/feature-settings-reorganization ← Head: vault/pm-3512/settings-appearance

📝 Commits (2)

  • d79914c PM-3512 Implemented new Appearance Settings
  • 8ca1623 PM-3512 Fix format

📊 Changes

27 files changed (+341 additions, -81 deletions)

View changed files

📝 src/Android/MainActivity.cs (+1 -1)
📝 src/App/App.xaml.cs (+1 -1)
📝 src/App/Controls/Settings/SwitchItemView.xaml (+3 -7)
📝 src/App/Pages/Accounts/HomePage.xaml.cs (+1 -1)
📝 src/App/Pages/Generator/GeneratorPage.xaml.cs (+2 -1)
📝 src/App/Pages/PickerViewModel.cs (+25 -4)
📝 src/App/Pages/Settings/AboutSettingsPage.xaml (+3 -8)
📝 src/App/Pages/Settings/AboutSettingsPage.xaml.cs (+1 -1)
📝 src/App/Pages/Settings/AppearanceSettingsPage.xaml (+44 -6)
📝 src/App/Pages/Settings/AppearanceSettingsPage.xaml.cs (+36 -4)
📝 src/App/Pages/Settings/AppearanceSettingsPageViewModel.cs (+193 -1)
📝 src/App/Pages/Settings/AutofillSettingsPage.xaml (+2 -6)
📝 src/App/Pages/Settings/AutofillSettingsPage.xaml.cs (+1 -1)
📝 src/App/Pages/Settings/OptionsPageViewModel.cs (+1 -1)
📝 src/App/Pages/Settings/OtherSettingsPage.xaml (+2 -8)
📝 src/App/Pages/Settings/OtherSettingsPage.xaml.cs (+1 -1)
📝 src/App/Pages/Settings/OtherSettingsPageViewModel.cs (+3 -7)
📝 src/App/Pages/Settings/SecuritySettingsPage.xaml (+2 -6)
📝 src/App/Pages/Settings/SecuritySettingsPage.xaml.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+1 -1)

...and 7 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implemented new view for settings: Appearance.

Code changes

  • PickerViewModel: Improved it to reuse code and also added afterSelectionChangedAsync to be able to perform actions after the picker selected value has been set.
  • AppearanceSettingsPage/ViewModel: Implemented new Appearance view with new PickerViewModel approach.
  • Other settings views: Made the navigation to not be modal, removed the toolbar item for the back button given that the default is being used and changed the base class to be BaseContentPage instead the modal one.
  • Other: Moved updatedTheme to a constant and updated everywhere to used that constant

Screenshots

Android Appearance Light

Android Appearance Light

Android Appearance Dark

Android Appearance Dark

iOS Appearance Light

iOS Appearance Light

iOS Appearance Dark

iOS Appearance Dark

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2703 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 8/17/2023 **Status:** ✅ Merged **Merged:** 8/18/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `vault/pm-2658/feature-settings-reorganization` ← **Head:** `vault/pm-3512/settings-appearance` --- ### 📝 Commits (2) - [`d79914c`](https://github.com/bitwarden/android/commit/d79914c295f1aac6f249bb3fb4aea91bf3710eb0) PM-3512 Implemented new Appearance Settings - [`8ca1623`](https://github.com/bitwarden/android/commit/8ca1623d8bd3f5d6814d3aad1dae43623d344d29) PM-3512 Fix format ### 📊 Changes **27 files changed** (+341 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+1 -1) 📝 `src/App/App.xaml.cs` (+1 -1) 📝 `src/App/Controls/Settings/SwitchItemView.xaml` (+3 -7) 📝 `src/App/Pages/Accounts/HomePage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Generator/GeneratorPage.xaml.cs` (+2 -1) 📝 `src/App/Pages/PickerViewModel.cs` (+25 -4) 📝 `src/App/Pages/Settings/AboutSettingsPage.xaml` (+3 -8) 📝 `src/App/Pages/Settings/AboutSettingsPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Settings/AppearanceSettingsPage.xaml` (+44 -6) 📝 `src/App/Pages/Settings/AppearanceSettingsPage.xaml.cs` (+36 -4) 📝 `src/App/Pages/Settings/AppearanceSettingsPageViewModel.cs` (+193 -1) 📝 `src/App/Pages/Settings/AutofillSettingsPage.xaml` (+2 -6) 📝 `src/App/Pages/Settings/AutofillSettingsPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Settings/OptionsPageViewModel.cs` (+1 -1) 📝 `src/App/Pages/Settings/OtherSettingsPage.xaml` (+2 -8) 📝 `src/App/Pages/Settings/OtherSettingsPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Settings/OtherSettingsPageViewModel.cs` (+3 -7) 📝 `src/App/Pages/Settings/SecuritySettingsPage.xaml` (+2 -6) 📝 `src/App/Pages/Settings/SecuritySettingsPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+1 -1) _...and 7 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implemented new view for settings: Appearance. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **PickerViewModel:** Improved it to reuse code and also added `afterSelectionChangedAsync` to be able to perform actions after the picker selected value has been set. * **AppearanceSettingsPage/ViewModel:** Implemented new Appearance view with new `PickerViewModel` approach. * **Other settings views:** Made the navigation to not be modal, removed the toolbar item for the back button given that the default is being used and changed the base class to be `BaseContentPage` instead the modal one. * **Other:** Moved `updatedTheme` to a constant and updated everywhere to used that constant ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### Android Appearance Light <img width="314" alt="Android Appearance Light" src="https://github.com/bitwarden/mobile/assets/15682323/7e1abe08-5190-4a0c-887e-19958783cf01"> ### Android Appearance Dark <img width="314" alt="Android Appearance Dark" src="https://github.com/bitwarden/mobile/assets/15682323/024df571-3643-4172-aad0-a003c23fc4b2"> ### iOS Appearance Light <img width="314" alt="iOS Appearance Light" src="https://github.com/bitwarden/mobile/assets/15682323/b409926e-1bc6-4e89-8522-da0fbc2a0d7e"> ### iOS Appearance Dark <img width="314" alt="iOS Appearance Dark" src="https://github.com/bitwarden/mobile/assets/15682323/eb9e8624-a898-4d17-9b48-83b265054c59"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:53:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34253
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?