github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2626] [CLOSED] [PM-3082] MutualTLS - Add Support of Client Certificate Authentication #34190

New Issue
Closed
opened 2026-04-21 01:50:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:50:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2626
Author: @oguzhane
Created: 7/19/2023
Status: ❌ Closed

Base: master ← Head: fb-mtls-support

📝 Commits (9)

  • 37897d6 functional mtls code
  • 36a6f9f prompt pksc12 cert
  • 20e7c5f fixes to import cert into keystore
  • e980007 code clean up
  • 1a13ecb i18n and UI improvements
  • d58806a support of importing cert chain
  • c34c1ea rename certificate chain spec
  • 35a4a93 support mTLS connection with cert chain
  • fb38fe0 reload client cert when changes

📊 Changes

29 files changed (+1075 additions, -69 deletions)

View changed files

📝 src/Android/Android.csproj (+15 -7)
📝 src/Android/MainActivity.cs (+42 -1)
📝 src/Android/MainApplication.cs (+3 -1)
➕ src/Android/Security/AndroidHttpsClientHandler.cs (+76 -0)
➕ src/Android/Security/X509CertificateChainSpec.cs (+42 -0)
➕ src/Android/Services/CertificateService.cs (+256 -0)
📝 src/Android/Services/FileService.cs (+47 -5)
📝 src/App/App.csproj (+4 -0)
➕ src/App/Pages/Accounts/AdvancedPage.xaml (+99 -0)
➕ src/App/Pages/Accounts/AdvancedPage.xaml.cs (+30 -0)
➕ src/App/Pages/Accounts/AdvancedPageViewModel.cs (+167 -0)
📝 src/App/Pages/Accounts/LoginPage.xaml (+8 -0)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+9 -0)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+11 -0)
📝 src/App/Resources/AppResources.Designer.cs (+70 -4)
📝 src/App/Resources/AppResources.en-GB.resx (+25 -19)
📝 src/App/Resources/AppResources.resx (+23 -2)
📝 src/App/Styles/Base.xaml (+6 -0)
📝 src/Core/Abstractions/IApiService.cs (+1 -0)
➕ src/Core/Abstractions/ICertificateService.cs (+17 -0)

...and 9 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2626 **Author:** [@oguzhane](https://github.com/oguzhane) **Created:** 7/19/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fb-mtls-support` --- ### 📝 Commits (9) - [`37897d6`](https://github.com/bitwarden/android/commit/37897d696bb418abfca4de13cfef12b01ac77ae7) functional mtls code - [`36a6f9f`](https://github.com/bitwarden/android/commit/36a6f9f36e1ae3cc00ad88568c787e8e31af6e66) prompt pksc12 cert - [`20e7c5f`](https://github.com/bitwarden/android/commit/20e7c5fcabe89cda718ae1530c406d70124af638) fixes to import cert into keystore - [`e980007`](https://github.com/bitwarden/android/commit/e980007e80fcf4f7b45efc6e3fdf1de9f1b7acb8) code clean up - [`1a13ecb`](https://github.com/bitwarden/android/commit/1a13ecb6b04d1ae597b25a82abb284de1f92a3bb) i18n and UI improvements - [`d58806a`](https://github.com/bitwarden/android/commit/d58806ac1a33334f47265b5d5538f3b5416de3c6) support of importing cert chain - [`c34c1ea`](https://github.com/bitwarden/android/commit/c34c1ead9b9d5ee1bcd35192e2e93eb3c74b597d) rename certificate chain spec - [`35a4a93`](https://github.com/bitwarden/android/commit/35a4a93e73c121cfbbd39442e637e63c53aafde0) support mTLS connection with cert chain - [`fb38fe0`](https://github.com/bitwarden/android/commit/fb38fe0af6ade1369a66e5f6906812ad59e68dd6) reload client cert when changes ### 📊 Changes **29 files changed** (+1075 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+15 -7) 📝 `src/Android/MainActivity.cs` (+42 -1) 📝 `src/Android/MainApplication.cs` (+3 -1) ➕ `src/Android/Security/AndroidHttpsClientHandler.cs` (+76 -0) ➕ `src/Android/Security/X509CertificateChainSpec.cs` (+42 -0) ➕ `src/Android/Services/CertificateService.cs` (+256 -0) 📝 `src/Android/Services/FileService.cs` (+47 -5) 📝 `src/App/App.csproj` (+4 -0) ➕ `src/App/Pages/Accounts/AdvancedPage.xaml` (+99 -0) ➕ `src/App/Pages/Accounts/AdvancedPage.xaml.cs` (+30 -0) ➕ `src/App/Pages/Accounts/AdvancedPageViewModel.cs` (+167 -0) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+8 -0) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+9 -0) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+11 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+70 -4) 📝 `src/App/Resources/AppResources.en-GB.resx` (+25 -19) 📝 `src/App/Resources/AppResources.resx` (+23 -2) 📝 `src/App/Styles/Base.xaml` (+6 -0) 📝 `src/Core/Abstractions/IApiService.cs` (+1 -0) ➕ `src/Core/Abstractions/ICertificateService.cs` (+17 -0) _...and 9 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:50:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?