github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2184] [MERGED] [SG-813] Not You? crashes app after vault logout timeout #3411

New Issue
Closed
opened 2025-11-26 23:32:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:32:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2184
Author: @andrebispo5
Created: 11/10/2022
Status: ✅ Merged
Merged: 11/11/2022
Merged by: @andrebispo5

Base: master ← Head: bugfix/SG-813-two-step-account-switch

📝 Commits (10+)

  • ffcb625 Merge branch 'master' into feature/SG-174-login-with-device
  • abc3646 [SG-813] Fix merge
  • 1e684f6 [SG-813] rename HomePage parameter name
  • 2f383f8 [SG-813] Added NavParams for home page on account switching.
  • 81c4057 [SG-813] Remove account showing when adding new account.
  • 22529fd [SG-813] Add account switch pop up if email already exists
  • 72a0967 [SG-813] Add default account avatar to HomePage
  • d2fd8c5 [SG-813] Code format
  • 860a2e1 [SG-813] Remove unused import
  • e02c0ee [SG-813] Renamed checkNavigateLogin to shouldCheckRememberEmail

📊 Changes

13 files changed (+123 additions, -57 deletions)

View changed files

📝 src/App/Abstractions/IAccountsManager.cs (+1 -0)
📝 src/App/App.xaml.cs (+8 -1)
📝 src/App/Pages/Accounts/HomePage.xaml.cs (+3 -3)
📝 src/App/Pages/Accounts/HomePageViewModel.cs (+21 -6)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+7 -7)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+12 -18)
📝 src/App/Utilities/AccountManagement/AccountsManager.cs (+16 -2)
➕ src/App/Utilities/AccountManagement/HomeNavigationParams.cs (+14 -0)
📝 src/Core/Abstractions/IStateService.cs (+1 -0)
📝 src/Core/Services/StateService.cs (+6 -0)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+14 -7)
📝 src/iOS.Extension/LoadingViewController.cs (+6 -6)
📝 src/iOS.ShareExtension/LoadingViewController.cs (+14 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If your account is set to logout on vault time-out, once your vault times out, if you click on “not you?” from the master password screen, the app crashes.

Steps to Reproduce:

  1. Login to account
  2. Set “vault timeout action” to “Logout”
  3. Let your vault timeout so it logs you out
  4. Click “not you?”

Expected: Taken to email screen

Actual: App crashes

Code changes

Renamed HomePage parameter checkRememberedEmail to checkNavigateToLogin, also made the change on iOS Extensions.

src/App/Utilities/AccountManagement/AccountsManager.cs:

  • Add account now navigates to HomePage.
  • VaultTimeout actions now navigates to the HomePage with a set remembered email as the VaultTimeout account, and with redirect to login page. This allows the user to click Not you? and go back to the HomePage.

Screenshots

IMG_5730
IMG_5731
IMG_2CC606322E06-1

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2184 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 11/10/2022 **Status:** ✅ Merged **Merged:** 11/11/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/SG-813-two-step-account-switch` --- ### 📝 Commits (10+) - [`ffcb625`](https://github.com/bitwarden/android/commit/ffcb6256e01f778ddb2fd00e5cc2ec82dc3f547c) Merge branch 'master' into feature/SG-174-login-with-device - [`abc3646`](https://github.com/bitwarden/android/commit/abc3646b28714ec74f587a31a776cc1ccd73197f) [SG-813] Fix merge - [`1e684f6`](https://github.com/bitwarden/android/commit/1e684f61235b8585a82a210817c79d3d77e0597f) [SG-813] rename HomePage parameter name - [`2f383f8`](https://github.com/bitwarden/android/commit/2f383f888d23f8152f724a24bc7ab2d0581cfe58) [SG-813] Added NavParams for home page on account switching. - [`81c4057`](https://github.com/bitwarden/android/commit/81c4057a4559686158d19268b5f470b0480b3d65) [SG-813] Remove account showing when adding new account. - [`22529fd`](https://github.com/bitwarden/android/commit/22529fded9c0da4945698fcbb3a514a218a72ba2) [SG-813] Add account switch pop up if email already exists - [`72a0967`](https://github.com/bitwarden/android/commit/72a0967d4b29cc09460422026b8001181d4f7cd2) [SG-813] Add default account avatar to HomePage - [`d2fd8c5`](https://github.com/bitwarden/android/commit/d2fd8c56ca928ef06b94abb5efb231a329da15e4) [SG-813] Code format - [`860a2e1`](https://github.com/bitwarden/android/commit/860a2e1396dc64852d7dc95808c0fda677562b7e) [SG-813] Remove unused import - [`e02c0ee`](https://github.com/bitwarden/android/commit/e02c0eec662d5babc5cbc760c766c7a331c6fffc) [SG-813] Renamed checkNavigateLogin to shouldCheckRememberEmail ### 📊 Changes **13 files changed** (+123 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Abstractions/IAccountsManager.cs` (+1 -0) 📝 `src/App/App.xaml.cs` (+8 -1) 📝 `src/App/Pages/Accounts/HomePage.xaml.cs` (+3 -3) 📝 `src/App/Pages/Accounts/HomePageViewModel.cs` (+21 -6) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+7 -7) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+12 -18) 📝 `src/App/Utilities/AccountManagement/AccountsManager.cs` (+16 -2) ➕ `src/App/Utilities/AccountManagement/HomeNavigationParams.cs` (+14 -0) 📝 `src/Core/Abstractions/IStateService.cs` (+1 -0) 📝 `src/Core/Services/StateService.cs` (+6 -0) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+14 -7) 📝 `src/iOS.Extension/LoadingViewController.cs` (+6 -6) 📝 `src/iOS.ShareExtension/LoadingViewController.cs` (+14 -7) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> If your account is set to logout on vault time-out, once your vault times out, if you click on “not you?” from the master password screen, the app crashes. ### Steps to Reproduce: 1. Login to account 2. Set “vault timeout action” to “Logout” 3. Let your vault timeout so it logs you out 4. Click “not you?” **Expected:** Taken to email screen **Actual:** App crashes ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Renamed HomePage parameter `checkRememberedEmail` to `checkNavigateToLogin`, also made the change on iOS Extensions. **src/App/Utilities/AccountManagement/AccountsManager.cs:** - Add account now navigates to `HomePage`. - `VaultTimeout` actions now navigates to the `HomePage` with a set remembered email as the VaultTimeout account, and with redirect to login page. This allows the user to click `Not you?` and go back to the `HomePage`. ## Screenshots ![IMG_5730](https://user-images.githubusercontent.com/4648522/201154819-83608cb0-c068-4e2d-99ee-dda1e4d2bf96.PNG) ![IMG_5731](https://user-images.githubusercontent.com/4648522/201154832-2e62efd5-a9a4-4c2d-b13a-c76edc591f70.PNG) ![IMG_2CC606322E06-1](https://user-images.githubusercontent.com/4648522/201154990-5135bbe1-9de5-4453-a362-2feb0ad5fa9e.jpeg) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:32:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?