github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2390] [MERGED] [PM-1078] Login with Device - Change mobile to not get fingerprint from API #34036

New Issue
Closed
opened 2026-04-21 01:42:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:42:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2390
Author: @andrebispo5
Created: 2/22/2023
Status: ✅ Merged
Merged: 3/13/2023
Merged by: @andrebispo5

Base: master ← Head: feature/PM-1078-fingerprint

📝 Commits (2)

  • b7658d8 [PM-1078] Fingerprint phrase gets calculated from pub key on AuthService instead of coming as a property from the api.
  • 0341c79 [PM-1078] Code format

📊 Changes

6 files changed (+34 additions, -9 deletions)

View changed files

📝 src/App/App.xaml.cs (+1 -1)
📝 src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs (+1 -1)
📝 src/App/Pages/Settings/LoginPasswordlessRequestsListPage.xaml (+1 -1)
📝 src/App/Pages/Settings/LoginPasswordlessRequestsListViewModel.cs (+1 -1)
📝 src/Core/Models/Response/PasswordlessLoginResponse.cs (+1 -1)
📝 src/Core/Services/AuthService.cs (+29 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

  • Modify mobile client to generate the fingerprint phrase themselves, ignoring the one retrieved from the API
  • Remove fingerprintPhrase from the AuthRequestResponse

Code changes

  • src/Core/Models/Response/PasswordlessLoginResponse.cs:
    Renamed property containing the FingerprintPhrase, ignoring api value.

  • src/Core/Services/AuthService.cs:
    After fetching the data from the ApiService, AuthService will populate the values for the FingerprintPhrase.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2390 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 2/22/2023 **Status:** ✅ Merged **Merged:** 3/13/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `feature/PM-1078-fingerprint` --- ### 📝 Commits (2) - [`b7658d8`](https://github.com/bitwarden/android/commit/b7658d882c779696dda0668b4579f3c402a8f703) [PM-1078] Fingerprint phrase gets calculated from pub key on AuthService instead of coming as a property from the api. - [`0341c79`](https://github.com/bitwarden/android/commit/0341c79ae3afeb661016fe2f37037802c04f58a5) [PM-1078] Code format ### 📊 Changes **6 files changed** (+34 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+1 -1) 📝 `src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs` (+1 -1) 📝 `src/App/Pages/Settings/LoginPasswordlessRequestsListPage.xaml` (+1 -1) 📝 `src/App/Pages/Settings/LoginPasswordlessRequestsListViewModel.cs` (+1 -1) 📝 `src/Core/Models/Response/PasswordlessLoginResponse.cs` (+1 -1) 📝 `src/Core/Services/AuthService.cs` (+29 -4) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> - Modify mobile client to generate the fingerprint phrase themselves, ignoring the one retrieved from the API - Remove fingerprintPhrase from the AuthRequestResponse ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/Core/Models/Response/PasswordlessLoginResponse.cs:** Renamed property containing the `FingerprintPhrase`, ignoring api value. * **src/Core/Services/AuthService.cs:** After fetching the data from the `ApiService`, `AuthService` will populate the values for the `FingerprintPhrase`. <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:42:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34036
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?