github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2166] [MERGED] [SG-800] Selecting notification for inactive account on iOS while app is open does not display the request #3401

New Issue
Closed
opened 2025-11-26 23:32:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:32:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2166
Author: @andrebispo5
Created: 11/4/2022
Status: ✅ Merged
Merged: 11/4/2022
Merged by: @andrebispo5

Base: master ← Head: SG-800-notification-tap-lock

📝 Commits (2)

  • 8fde86b [SG-800] Remove await from ActionSheet
  • e6c3515 [SG-800] Add try catch

📊 Changes

1 file changed (+12 additions, -5 deletions)

View changed files

📝 src/App/App.xaml.cs (+12 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix bug where If the user never answers the switch accounts pop up, the lock is never released. This was problematic because when tapping a notification while pop-up was showing, the user navigates to the other account automatically and the pop-up is never dismissed.

Code changes

Removed await to allow the execution flow and lock to be released.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2166 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 11/4/2022 **Status:** ✅ Merged **Merged:** 11/4/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `SG-800-notification-tap-lock` --- ### 📝 Commits (2) - [`8fde86b`](https://github.com/bitwarden/android/commit/8fde86be2f679ca08ccfdbac6f50b755d07b0d10) [SG-800] Remove await from ActionSheet - [`e6c3515`](https://github.com/bitwarden/android/commit/e6c3515a4c92f7f9e7b299602bfd2efcfc7108c6) [SG-800] Add try catch ### 📊 Changes **1 file changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+12 -5) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix bug where If the user never answers the switch accounts pop up, the lock is never released. This was problematic because when tapping a notification while pop-up was showing, the user navigates to the other account automatically and the pop-up is never dismissed. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Removed await to allow the execution flow and lock to be released. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:32:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?