github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-26 22:04:07 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2309] [MERGED] Argon2id KDF #33996

New Issue
Closed
opened 2026-04-21 01:40:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:40:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2309
Author: @kspearrin
Created: 1/19/2023
Status: ✅ Merged
Merged: 1/25/2023
Merged by: @kspearrin

Base: master ← Head: argon2ios

📝 Commits (10+)

📊 Changes

18 files changed (+110 additions, -33 deletions)

View changed files

📝 .gitignore (+1 -0)
➕ lib/ios/libargon2.a (+0 -0)
📝 src/Android/Android.csproj (+4 -0)
📝 src/Android/Services/CryptoPrimitiveService.cs (+16 -0)
➕ src/Android/lib/arm64-v8a/libargon2.so (+0 -0)
➕ src/Android/lib/armeabi-v7a/libargon2.so (+0 -0)
➕ src/Android/lib/x86/libargon2.so (+0 -0)
➕ src/Android/lib/x86_64/libargon2.so (+0 -0)
📝 src/Core/Abstractions/ICryptoFunctionService.cs (+4 -0)
📝 src/Core/Abstractions/ICryptoPrimitiveService.cs (+1 -0)
📝 src/Core/Enums/KdfType.cs (+2 -1)
📝 src/Core/Services/CryptoService.cs (+8 -0)
📝 src/Core/Services/PclCryptoFunctionService.cs (+22 -0)
📝 src/iOS.Autofill/iOS.Autofill.csproj (+8 -8)
📝 src/iOS.Core/Services/CryptoPrimitiveService.cs (+21 -0)
📝 src/iOS.Extension/iOS.Extension.csproj (+8 -8)
📝 src/iOS.ShareExtension/iOS.ShareExtension.csproj (+8 -8)
📝 src/iOS/iOS.csproj (+7 -8)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add mobile app support for Argon2id as KDF.

Code changes

  • gitignore: exclude argon2 android libs from being ignored
  • lib/ios: argon2 precompiled c libs for ios
  • Android/lib: argon2 precompiled c libs for android
  • Android.csproj: Add references to argon2 c libs
  • Android/Services/CryptoPrimitiveService: Add argon2 p-invoke to c libs. Expose Argon2 public function.
  • Core/Enums/KdfType: Add type for Argon2
  • Core/Abstractions/ICryptoFunctionService: Add Argon2 interface
  • Core/Abstractions/ICryptoPrimitiveService: Add Argon2 interface
  • Core/Services/CryptoService: Add Argon2 implementation
  • Core/Services/PclCryptoFunctionService: Add Argon2 implementation
  • iOS.Core/CryptoPrimitiveService: Add argon2 p-invoke to c libs. Expose Argon2 public function.
  • iOS.*.csproj: Add references to argon2 c libs

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2309 **Author:** [@kspearrin](https://github.com/kspearrin) **Created:** 1/19/2023 **Status:** ✅ Merged **Merged:** 1/25/2023 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `argon2ios` --- ### 📝 Commits (10+) - [`0485c5e`](https://github.com/bitwarden/android/commit/0485c5ed17ed733909f507765ddc37c783088a28) add gcc_flags for libargon2.a - [`bb1eb1f`](https://github.com/bitwarden/android/commit/bb1eb1fbf5ec3452169354e7eb2eed2bd5061f8c) fix up ios proj - [`f917b3d`](https://github.com/bitwarden/android/commit/f917b3d939362ff59b266f8f1596bfb67ccfc71e) remove unused tag - [`df12e7d`](https://github.com/bitwarden/android/commit/df12e7dbd9c375eee1cadb567d86eee80cbbaa3b) add gcc_flags to ios projects - [`7da7238`](https://github.com/bitwarden/android/commit/7da7238405ad222359c514b2a3d75fc8e321c7ca) ios libargon2 binary - [`c3daa89`](https://github.com/bitwarden/android/commit/c3daa89ff740f37e0b0cb143712bae784599b488) fix paths in ios project - [`53ebad9`](https://github.com/bitwarden/android/commit/53ebad9a7de263c1a5003259278a7c15ac0e4872) update pathing on other projs - [`8b5f9d8`](https://github.com/bitwarden/android/commit/8b5f9d8529ac4c66758face566fcb8f65dbcde8b) Argon2id primitive - [`c4a7aab`](https://github.com/bitwarden/android/commit/c4a7aab590b646bdc41391b06d6515cc46a622ab) fix typing issues - [`270bf11`](https://github.com/bitwarden/android/commit/270bf114c35d1013dec8c957614f07b0438a2f46) comment ### 📊 Changes **18 files changed** (+110 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `lib/ios/libargon2.a` (+0 -0) 📝 `src/Android/Android.csproj` (+4 -0) 📝 `src/Android/Services/CryptoPrimitiveService.cs` (+16 -0) ➕ `src/Android/lib/arm64-v8a/libargon2.so` (+0 -0) ➕ `src/Android/lib/armeabi-v7a/libargon2.so` (+0 -0) ➕ `src/Android/lib/x86/libargon2.so` (+0 -0) ➕ `src/Android/lib/x86_64/libargon2.so` (+0 -0) 📝 `src/Core/Abstractions/ICryptoFunctionService.cs` (+4 -0) 📝 `src/Core/Abstractions/ICryptoPrimitiveService.cs` (+1 -0) 📝 `src/Core/Enums/KdfType.cs` (+2 -1) 📝 `src/Core/Services/CryptoService.cs` (+8 -0) 📝 `src/Core/Services/PclCryptoFunctionService.cs` (+22 -0) 📝 `src/iOS.Autofill/iOS.Autofill.csproj` (+8 -8) 📝 `src/iOS.Core/Services/CryptoPrimitiveService.cs` (+21 -0) 📝 `src/iOS.Extension/iOS.Extension.csproj` (+8 -8) 📝 `src/iOS.ShareExtension/iOS.ShareExtension.csproj` (+8 -8) 📝 `src/iOS/iOS.csproj` (+7 -8) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Add mobile app support for Argon2id as KDF. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **gitignore:** exclude argon2 android libs from being ignored * **lib/ios:** argon2 precompiled c libs for ios * **Android/lib:** argon2 precompiled c libs for android * **Android.csproj:** Add references to argon2 c libs * **Android/Services/CryptoPrimitiveService:** Add argon2 p-invoke to c libs. Expose Argon2 public function. * **Core/Enums/KdfType:** Add type for Argon2 * **Core/Abstractions/ICryptoFunctionService:** Add Argon2 interface * **Core/Abstractions/ICryptoPrimitiveService:** Add Argon2 interface * **Core/Services/CryptoService:** Add Argon2 implementation * **Core/Services/PclCryptoFunctionService:** Add Argon2 implementation * **iOS.Core/CryptoPrimitiveService:** Add argon2 p-invoke to c libs. Expose Argon2 public function. * **iOS.*.csproj:** Add references to argon2 c libs ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:40:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#33996