github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2159] [MERGED] [SG-765] Add cancel button to passwordless login modal on android #3395

New Issue
Closed
opened 2025-11-26 23:32:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:32:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2159
Author: @andrebispo5
Created: 10/31/2022
Status: ✅ Merged
Merged: 10/31/2022
Merged by: @andrebispo5

Base: master ← Head: bugfix/SG-765-droid-cancel-button

📝 Commits (1)

  • f75cc95 [SG-765] Add cancel button to passwordless login modal on android

📊 Changes

1 file changed (+1 additions, -4 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs (+1 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add a cancel button to the login request modal on Android.

Screenshots

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2159 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 10/31/2022 **Status:** ✅ Merged **Merged:** 10/31/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/SG-765-droid-cancel-button` --- ### 📝 Commits (1) - [`f75cc95`](https://github.com/bitwarden/android/commit/f75cc95ccee9e238aa84541abc28759dbe74550f) [SG-765] Add cancel button to passwordless login modal on android ### 📊 Changes **1 file changed** (+1 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs` (+1 -4) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add a cancel button to the login request modal on Android. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="435" alt="image" src="https://user-images.githubusercontent.com/4648522/199034023-d7cf9cbc-9c0a-473e-b9fc-4d046ccd8adb.png"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:32:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?