github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2154] [MERGED] Fix for avatar sequence issue on iOS account switching modal #3391

New Issue
Closed
opened 2025-11-26 23:32:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:32:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2154
Author: @mpbw2
Created: 10/27/2022
Status: ✅ Merged
Merged: 10/27/2022
Merged by: @mpbw2

Base: master ← Head: bugfix-avatarhash

📝 Commits (1)

  • be1df11 added missing id check to obj comparison

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/App/Controls/AvatarImageSource.cs (+2 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The order of avatars (not accounts) would invert each time the account switching list was opened on iOS. Missed it the first time through due to the subtle earth-tones all my test accounts ended up with.

Code changes

  • AvatarImageSource.cs: Added missing _id check to Equals fixed the object comparison (thanks @fedemkr )

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2154 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/27/2022 **Status:** ✅ Merged **Merged:** 10/27/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-avatarhash` --- ### 📝 Commits (1) - [`be1df11`](https://github.com/bitwarden/android/commit/be1df119eac33825e8ef784aeba97b9c08cb40ea) added missing id check to obj comparison ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/AvatarImageSource.cs` (+2 -2) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> The order of avatars (not accounts) would invert each time the account switching list was opened on iOS. Missed it the first time through due to the subtle earth-tones all my test accounts ended up with. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AvatarImageSource.cs:** Added missing `_id` check to `Equals` fixed the object comparison (thanks @fedemkr ) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:32:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3391
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?