github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2178] [CLOSED] Remove 'Remove Account' option from login page #33908

New Issue
Closed
opened 2026-04-21 01:35:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:35:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2178
Author: @differsthecat
Created: 11/9/2022
Status: ❌ Closed

Base: master ← Head: SG-808

📝 Commits (2)

  • a384aea Remove 'Remove Account' option from login page
  • 5014041 Remove options on login page

📊 Changes

3 files changed (+0 additions, -68 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPage.xaml (+0 -14)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+0 -35)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+0 -19)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Remove options from the login page altogether as the items in it are redundant with the updates.

Code changes

  • src/App/Pages/Accounts/LoginPage.xaml: Remove options
  • src/App/Pages/Accounts/LoginPage.xaml.cs: Remove Android specific check on the removeAccount option
  • src/App/Pages/Accounts/LoginPageViewModel.cs: Remove options

Screenshots

Screen Shot 2022-11-09 at 10 34 36 AM

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2178 **Author:** [@differsthecat](https://github.com/differsthecat) **Created:** 11/9/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `SG-808` --- ### 📝 Commits (2) - [`a384aea`](https://github.com/bitwarden/android/commit/a384aea7319e73bad4f3c4b6adb27f614675a60c) Remove 'Remove Account' option from login page - [`5014041`](https://github.com/bitwarden/android/commit/5014041211f343fd671be4ae1bb8dd6f31b00820) Remove options on login page ### 📊 Changes **3 files changed** (+0 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+0 -14) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+0 -35) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+0 -19) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Remove options from the login page altogether as the items in it are redundant with the updates. ## Code changes - **src/App/Pages/Accounts/LoginPage.xaml:** Remove options - **src/App/Pages/Accounts/LoginPage.xaml.cs:** Remove Android specific check on the removeAccount option - **src/App/Pages/Accounts/LoginPageViewModel.cs:** Remove options ## Screenshots ![Screen Shot 2022-11-09 at 10 34 36 AM](https://user-images.githubusercontent.com/8926729/200876582-b275d653-287e-4649-b25c-b6b991e72d4b.png) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:35:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#33908
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?