github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 12:58:36 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2044] [MERGED] [PS-1352] Fix ignore diacritics in search #33816

New Issue
Closed
opened 2026-04-21 01:31:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:31:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2044
Author: @noncenz
Created: 8/22/2022
Status: ✅ Merged
Merged: 1/5/2023
Merged by: @aj-rosado

Base: master ← Head: fix-ignore-diacritics-in-search

📝 Commits (4)

  • 733464e Fix ignore diacritics in search
  • a0e6277 Merge branch 'master' into fix-ignore-diacritics-in-search
  • 6b77fee Merge branch 'master' into fix-ignore-diacritics-in-search
  • afceaa8 Removed logs, added null or whitespace validation and improved formatting

📊 Changes

2 files changed (+38 additions, -3 deletions)

View changed files

📝 src/Core/Services/SearchService.cs (+4 -3)
➕ src/Core/Utilities/StringExtensions.cs (+34 -0)

📄 Description

This change updates the search function to ignore diacritical marks in search results. Marks are stripped from both the search input and results.

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes #2008

Search results should match on base characters, ignoring any accents or other glyphs applied to the search term or the stored data.

Code changes

/src/Core/Utilities/StringExtensions.cs - Added new file to contain String extension to normalize strings by removing diacritics.

/src/Core/Services/SerachService.cs - Applied String extension to search term, item name and item subtitle.

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2044 **Author:** [@noncenz](https://github.com/noncenz) **Created:** 8/22/2022 **Status:** ✅ Merged **Merged:** 1/5/2023 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `fix-ignore-diacritics-in-search` --- ### 📝 Commits (4) - [`733464e`](https://github.com/bitwarden/android/commit/733464e05dd7f299041d31d86f11985806823fd6) Fix ignore diacritics in search - [`a0e6277`](https://github.com/bitwarden/android/commit/a0e62771fd884ec6ca2ae528b0a6893a3c7db510) Merge branch 'master' into fix-ignore-diacritics-in-search - [`6b77fee`](https://github.com/bitwarden/android/commit/6b77fee72b6506752f9688a1c1960b1bed35044b) Merge branch 'master' into fix-ignore-diacritics-in-search - [`afceaa8`](https://github.com/bitwarden/android/commit/afceaa8a4b212d14d20a16185f0c7953ba58162d) Removed logs, added null or whitespace validation and improved formatting ### 📊 Changes **2 files changed** (+38 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/SearchService.cs` (+4 -3) ➕ `src/Core/Utilities/StringExtensions.cs` (+34 -0) </details> ### 📄 Description This change updates the search function to ignore diacritical marks in search results. Marks are stripped from both the search input and results. ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fixes #2008 Search results should match on base characters, ignoring any accents or other glyphs applied to the search term or the stored data. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> `/src/Core/Utilities/StringExtensions.cs` - Added new file to contain String extension to normalize strings by removing diacritics. `/src/Core/Services/SerachService.cs` - Applied String extension to search term, item name and item subtitle. ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:31:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#33816
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?